Repository navigation
Conversation
Test coverage instrumented loses its instrumentation properties when
properties from normal command replaces all properties on the
kotl-mode command. This likely affects debug instrumentation as well
since test cover uses the debug instrumentation for its functionality.
The effects of this can be viewed by running:
make docker version=master targets='clean bin coverage file=kotl/kotl-mode.el'
This handles the properties by only copying a selected set of
properties, in kotl-mode:inherited-command-properties, to the
kotl-mode commands. This preserves any properties that the kotl-mode
command may already have and will by that not touch test coverage and
debug proprieties.
* kotl/kotl-mode.el (kotl-mode:inherited-command-properties):
Properties local command shall inherit.
(kotl-mode:set-inherited-properties): Set the inherited properties.
(kotl-mode:setup-keymap): Use kotl-mode:set-inherited-properties.
* kotl/kotl-orgtbl.el (kotl-mode:set-inherited-properties): Declare function.
(kotl-mode:setup-overriding-orgtbl-keymap): Use kotl-mode:set-inherited-properties.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Test coverage instrumented loses its instrumentation properties when
properties from normal command replaces all properties on the
kotl-mode command. This likely affects debug instrumentation as well
since test cover uses the debug instrumentation for its functionality.
The effects of this can be viewed by running:
This handles the properties by only copying a selected set of
properties, in kotl-mode:inherited-command-properties, to the
kotl-mode commands. This preserves any properties that the kotl-mode
command may already have and will by that not touch test coverage and
debug proprieties.
kotl/kotl-mode.el (kotl-mode:inherited-command-properties):
Properties local command shall inherit.
(kotl-mode:set-inherited-properties): Set the inherited properties.
(kotl-mode:setup-keymap): Use kotl-mode:set-inherited-properties.
kotl/kotl-orgtbl.el (kotl-mode:set-inherited-properties): Declare function.
(kotl-mode:setup-overriding-orgtbl-keymap): Use kotl-mode:set-inherited-properties.
Why
Test coverage for kotl-mode is not possible to properly produce
without this. Possibly other implications as well as affecting
debugging.