Skip to content

Copy selected properties to local command, don't remove existing - #1100

Open
matsl wants to merge 1 commit into
masterfrom
pr_fix_symbol_plist_with_testcover_n_edebug
Open

matsl wants to merge 1 commit into
masterfrom
pr_fix_symbol_plist_with_testcover_n_edebug

Conversation

@matsl

@matsl matsl commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

What

Test coverage instrumented loses its instrumentation properties when
properties from normal command replaces all properties on the
kotl-mode command. This likely affects debug instrumentation as well
since test cover uses the debug instrumentation for its functionality.

The effects of this can be viewed by running:

make docker version=master targets='clean bin coverage file=kotl/kotl-mode.el'

This handles the properties by only copying a selected set of
properties, in kotl-mode:inherited-command-properties, to the
kotl-mode commands. This preserves any properties that the kotl-mode
command may already have and will by that not touch test coverage and
debug proprieties.

  • kotl/kotl-mode.el (kotl-mode:inherited-command-properties):
    Properties local command shall inherit.
    (kotl-mode:set-inherited-properties): Set the inherited properties.
    (kotl-mode:setup-keymap): Use kotl-mode:set-inherited-properties.

  • kotl/kotl-orgtbl.el (kotl-mode:set-inherited-properties): Declare function.
    (kotl-mode:setup-overriding-orgtbl-keymap): Use kotl-mode:set-inherited-properties.

Why

Test coverage for kotl-mode is not possible to properly produce
without this. Possibly other implications as well as affecting
debugging.

Test coverage instrumented loses its instrumentation properties when
properties from normal command replaces all properties on the
kotl-mode command. This likely affects debug instrumentation as well
since test cover uses the debug instrumentation for its functionality.

The effects of this can be viewed by running:

    make docker version=master targets='clean bin coverage file=kotl/kotl-mode.el'

This handles the properties by only copying a selected set of
properties, in kotl-mode:inherited-command-properties, to the
kotl-mode commands. This preserves any properties that the kotl-mode
command may already have and will by that not touch test coverage and
debug proprieties.

* kotl/kotl-mode.el (kotl-mode:inherited-command-properties):
Properties local command shall inherit.
(kotl-mode:set-inherited-properties): Set the inherited properties.
(kotl-mode:setup-keymap): Use kotl-mode:set-inherited-properties.

* kotl/kotl-orgtbl.el (kotl-mode:set-inherited-properties): Declare function.
(kotl-mode:setup-overriding-orgtbl-keymap): Use kotl-mode:set-inherited-properties.
@matsl matsl self-assigned this Nov 17, 2026
@matsl
matsl requested a review from rswgnu November 17, 2026 12:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant