Repository navigation
Remove issues with byte compiling test files and their resources - #1102
Merged
matsl merged 1 commit intoNov 18, 2026
Merged
Conversation
Package managers byte compile el-files in subfolders. Errors and warnings there will confuse users there are problems. This fixes the current issues. * test/hywiki-yki-tests.el: Uses el-mock so should not be byte-compiled. * test/hy-string-tests.el (debug-in-string): Remove unused var len and extra values in format previously moved into vars. * test/hmouse-drv-resources/test-data.el: * test/hibtypes-resources/test-data.el: Enable lexical binding.
rswgnu
approved these changes
Nov 18, 2026
matsl
deleted the
pr_remove_byte-compile_issues_for_tests_and_resources
branch
November 18, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Package managers byte compile el-files in subfolders. Errors and
warnings there will confuse users there are problems. This fixes the
current issues.
test/hywiki-yki-tests.el: Uses el-mock so should not be byte-compiled.
test/hy-string-tests.el (debug-in-string): Remove unused var len and
extra values in format previously moved into vars.
test/hmouse-drv-resources/test-data.el:
test/hibtypes-resources/test-data.el: Enable lexical binding.
Why
When installing Hyperbole warnings and errors when byte compiling test
files and resources confuses users. This silences the current issues.