Conversation
* test/hywiki-tests.el (hywiki-tests--verify-removal-of-delimiter-updates-face):
(hywiki-tests--wikiword-yanked-with-extra-words):
(hywiki-tests--create-wikiword-file-highlights-wikiword): Use
hywiki-tests--with-face-test default value.
* test/hywiki-yki-tests.el (hywiki--verify-get-buffer-text-with-point-and-highlight-compact):
Use hywiki-tests--with-face-test default value. Let
hywiki-tests--preserve-hywiki-mode handle wikiword file and hywiki-directory.
rswgnu
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use default value for face test flag.
(hywiki-tests--wikiword-yanked-with-extra-words):
(hywiki-tests--create-wikiword-file-highlights-wikiword): Use
hywiki-tests--with-face-test default value.
Use hywiki-tests--with-face-test default value. Let
hywiki-tests--preserve-hywiki-mode handle wikiword file and hywiki-directory.
Why
The face test flag is per default t so we should only set it to nil in
the cases where we don't want to verify the face. This is a left over
from the initial test for faces where the highlighting did not work
properly.
The hywiki-tests--preserve-hywiki-mode macro handles the removal of
the hywiki-directory and also creates the first WikiWord for the
tests. Test should just use that when applicable.