fix(container): surface docker health status in rtk docker ps output#1845
Open
Donotavio wants to merge 1 commit into
Open
fix(container): surface docker health status in rtk docker ps output#1845Donotavio wants to merge 1 commit into
Donotavio wants to merge 1 commit into
Conversation
docker ps already fetches {{.Status}} which includes health state:
'Up 2 hours (healthy)', 'Up 1 hour (unhealthy)'
but docker_ps() parsed parts[2] and discarded it silently. An AI agent
monitoring containers could not detect unhealthy services.
Changes:
- Extract format_docker_ps_line(parts) as pub(crate) pure function
so it can be unit-tested without spawning docker
- Include status in output between name and image
- Prefix unhealthy containers with [!] for immediate visibility
- Extract trim_image_registry() helper, eliminating duplication
with format_compose_ps() which had the same split('/').next_back()
- Add UNHEALTHY_PREFIX const to avoid magic string duplication
- Add 7 targeted tests covering healthy, unhealthy, exited,
restarting states and the None guard for malformed input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
`rtk docker ps` fetches `{{.Status}}` which already includes health state when configured:
```
Up 2 hours (healthy)
Up 1 hour (unhealthy)
```
But `docker_ps()` parsed `parts[2]` (Status field) and discarded it completely. An AI agent monitoring containers had no way to identify unhealthy services.
Fix
Refactoring
Tests
7 new unit tests: