Repository navigation
[Documentation] Include shadcn/ui MIT notice in LICENSE.txt - #577
Merged
Merged
Conversation
RubyUI components derive from shadcn/ui (MIT), whose license requires the copyright and permission notice in copies. Append it to LICENSE.txt under a third-party notices section and point the README license section at LICENSE.txt instead of shadcn's license file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…ether Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
No issue. Found while checking shadcn/ui's license for the shadcn-audit work.
Description
RubyUI's component styles, structure and examples come from shadcn/ui, which is MIT licensed. MIT asks for one thing: ship shadcn's copyright and permission notice with copies or substantial portions. The gem didn't.
gem/LICENSE.txtkeeps RubyUI's MIT text and adds a "Third-party notices" section with shadcn's license verbatim (Copyright (c) 2023 shadcn). The file already ships in the gem throughs.files.gem/README.md's License section used to link shadcn's LICENSE as if it were RubyUI's. It now linksLICENSE.txtand credits shadcn there.gem/test/license_test.rbchecks the notice is present, that the gemspec shipsLICENSE.txt, and that the README no longer points at shadcn's license as ours.No per-file headers: shadcn's own CLI copies components into apps without them, and the notice travels with the gem.
Testing instructions
cd gem && bundle exec rake(297 runs, 0 failures; standardrb clean).gem build ruby_ui.gemspec && tar -xOf ruby_ui-*.gem data.tar.gz | tar -tz | grep LICENSElistsLICENSE.txt; its tail is shadcn's MIT notice.🤖 Generated with Claude Code