Skip to content

[Documentation] Audit: register Dialog reduced-motion divergence - #585

Open
cirdes wants to merge 1 commit into
mainfrom
audit/dialog-reduced-motion-divergence
Open

cirdes wants to merge 1 commit into
mainfrom
audit/dialog-reduced-motion-divergence

Conversation

@cirdes

@cirdes cirdes commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Since #580, Dialog skips its open and close animations when the OS asks for reduced motion (motion-reduce:animate-none! on the panel and on ::backdrop). shadcn Base UI runs the animations either way, so /shadcn-audit flags the extra tokens. This registers the difference in audit/divergences.yml, and the audit now grades that line as intentional.

No component code changes.

Testing instructions

  1. cd audit && bundle exec rake test
  2. bundle exec exe/shadcn-audit divergences dialog lists three entries, the last one with dimension Animation.

🤖 Generated with Claude Code


Summary by cubic

Registers the Dialog reduced-motion divergence in audit/divergences.yml so the audit now grades that difference as intentional. RubyUI Dialog respects prefers-reduced-motion (skips open/close animations), while shadcn Base UI always runs them; no component code changes.

Written for commit 94a57b9. Summary will update on new commits.

View guided diff Turn on auto-fix

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Turn on auto-fix | Re-trigger cubic

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant