Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since #580, Dialog skips its open and close animations when the OS asks for reduced motion (
motion-reduce:animate-none!on the panel and on::backdrop). shadcn Base UI runs the animations either way, so/shadcn-auditflags the extra tokens. This registers the difference inaudit/divergences.yml, and the audit now grades that line as intentional.No component code changes.
Testing instructions
cd audit && bundle exec rake testbundle exec exe/shadcn-audit divergences dialoglists three entries, the last one with dimensionAnimation.🤖 Generated with Claude Code
Summary by cubic
Registers the Dialog reduced-motion divergence in
audit/divergences.ymlso the audit now grades that difference as intentional. RubyUI Dialog respectsprefers-reduced-motion(skips open/close animations), while shadcn Base UI always runs them; no component code changes.Written for commit 94a57b9. Summary will update on new commits.