Fix encoding crash when LANG environment is empty#1144
Merged
ko1 merged 3 commits intoruby:masterfrom Jun 5, 2025
Merged
Conversation
Collaborator
|
irb seems to handle encoding, but it is not stuck on UTF-8. ko1@WSL2 ~/ruby/gems/debug
[master]$ irb
irb(main):001> 'あいうえお'
=> "あいうえお"
irb(main):002>
[master]$ tail ~/.irb_history
...
'あいうえお'
[master]$ LANG=C irb
irb(main):001> '???????????????'
=> "???????????????"
irb(main):002>So I think
seems better. |
Contributor
Author
|
@ko1 Fixed! Using |
Collaborator
|
Thank you!! |
❌ Tests Failed✖️no tests failed ✔️74 tests passed(2 flakes) |
6cbefbd to
209f492
Compare
This was referenced Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes encoding crash when
LANG=(empty) by usingString#scrubto handle invalid characters gracefully.Problem
When
LANG=, debugger crashes withEncoding::CompatibilityErroron history files with UTF-8 characters.Solution
Use
String#scrubto clean problematic characters instead of forcing UTF-8 encoding.Testing
LANG= ruby -e 'require "debug"; debugger'now worksFixes #1131