Skip to content

RubyGems: Remove unused ctx.tmp_dh_callback in start_ssl_server #9633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 1 commit into from
Jun 23, 2026
+0 −15
Merged

RubyGems: Remove unused ctx.tmp_dh_callback in start_ssl_server #9633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions test/rubygems/test_gem_remote_fetcher_local_ssl_server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,6 @@
class TestGemRemoteFetcherLocalSSLServer < Gem::TestCase
include Gem::DefaultUserInteraction

# Generated via:
# x = OpenSSL::PKey::DH.new(2048) # wait a while...
# x.to_s => pem
TEST_KEY_DH2048 = OpenSSL::PKey::DH.new <<-_END_OF_PEM_
-----BEGIN DH PARAMETERS-----
MIIBCAKCAQEA3Ze2EHSfYkZLUn557torAmjBgPsqzbodaRaGZtgK1gEU+9nNJaFV
G1JKhmGUiEDyIW7idsBpe4sX/Wqjnp48Lr8IeI/SlEzLdoGpf05iRYXC8Cm9o8aM
cfmVgoSEAo9YLBpzoji2jHkO7Q5IPt4zxbTdlmmGFLc/GO9q7LGHhC+rcMcNTGsM
49AnILNn49pq4Y72jSwdmvq4psHZwwFBbPwLdw6bLUDDCN90jfqvYt18muwUxDiN
NP0fuvVAIB158VnQ0liHSwcl6+9vE1mL0Jo/qEXQxl0+UdKDjaGfTsn6HIrwTnmJ
PeIQQkFng2VVot/WAQbv3ePqWq07g1BBcwIBAg==
-----END DH PARAMETERS-----
_END_OF_PEM_

def setup
super
@ssl_server_thread = nil
Expand Down Expand Up @@ -155,7 +141,6 @@ def start_ssl_server(config = {})
ctx.cert = cert("ssl_cert.pem")
ctx.key = key("ssl_key.pem")
ctx.ca_file = File.join(__dir__, "ca_cert.pem")
ctx.tmp_dh_callback = proc { TEST_KEY_DH2048 }
ctx.verify_mode = config[:verify_mode] if config[:verify_mode]
@ssl_server = OpenSSL::SSL::SSLServer.new(server, ctx)
@ssl_server_thread = Thread.new do
Expand Down