Change ActiveRecord::Migration to ActiveRecord::Migration[7.1] by lenikadali · Pull Request #788 · rubyforgood/Flaredown

lenikadali · 2025-03-10T13:01:44Z

Changed the line ActiveRecord::Migration to ActiveRecord::Migration[7.1] so that schema loading could work (it is now required for newer versions of Rails)
Updated and commented out the load schema task since it fails to find and run the loading of data into the database PostgreSQL container
Added the initialize_profile method and add it to the after_create portion of the User factory because of the NameError I encountered:

NameError: undefined local variable or method `init_profile' for #<FactoryBot::SyntaxRunner:0x00007eaac2e3c560> (NameError)

lenikadali · 2025-03-10T13:14:16Z

backend/spec/factories/users.rb

+  def initialize_profile
+    create_profile!(
+      checkin_reminder: true,
+      onboarding_step_id: "onboarding-personal",
+      most_recent_doses: {},
+      most_recent_conditions_positions: {},
+      most_recent_symptoms_positions: {},
+      most_recent_treatments_positions: {}
+    )
+  end
+
  factory :user do
    sequence(:email) { |number| "user#{number}@example.com" }
    password { "password123" }
    password_confirmation { "password123" }
+    after(:create) { initialize_profile }


Modified the User factory to have the init_profile model from the User model and renamed it to initialize_profile because of the error below:

Done. bin/rails aborted! NameError: undefined local variable or method `init_profile' for #<FactoryBot::SyntaxRunner:0x00007eaac2e3c560> (NameError) after(:create) { init_profile } ^^^^^^^^^^^^ Did you mean? initialize /app/spec/factories/users.rb:45:in `block (3 levels) in <top (required)>' /app/db/seeds/development/users.seeds.rb:4:in `block in evaluate' /app/db/seeds/development/users.seeds.rb:3:in `each' /app/db/seeds/development/users.seeds.rb:3:in `evaluate' Tasks: TOP => db:seed => db:seed:development => db:seed:development:users (See full trace by running task with --trace)

lenikadali · 2025-03-10T13:14:22Z

backend/lib/tasks/app.rake

+      Rake::Task["db:migrate"].invoke
    end
-    Rake::Task["db:structure:load"].invoke
+    #Rake::Task["db:schema:load"].invoke


Had to comment out the db:schema:load task, after updating from db:structure:load since this was removed in Rails 6.2, in order to be able to run the rails app:setup command.

The error I got when I tried to run rails db:schema:load independently was:

psql:/app/db/structure.sql:60: ERROR: relation "ar_internal_metadata" already exists bin/rails aborted! failed to execute: psql --set ON_ERROR_STOP=1 --quiet --no-psqlrc --output /dev/null --file /app/db/structure.sql flaredown_development Please check the output above for any errors and make sure that `psql` is installed in your PATH and has proper permissions. /app/lib/tasks/app.rake:47:in `build_database' /app/lib/tasks/app.rake:32:in `setup' /app/lib/tasks/app.rake:4:in `block (2 levels) in <top (required)>' Tasks: TOP => db:schema:load (See full trace by running task with --trace)

It seems psql needs to be installed in the Rails container in order for the schema loading to work. Not sure why since pg is in the backend/Gemfile and I would think that should cover the database connection needs for the app.

I'm curious if it would work as intended if we put the db:migrate here, and then the schema:load within the Rails.env.development? block. I'm not sure if this is ran in our deploy process for production anyway, or this is generally just used for development purposes.

I wouldn't know since I was running this for development setup purposes 🙃
Maybe the contributors who've deployed Flaredown in production can comment?

compwron

This is looking good!!

haydenrou

thank you! Just left a couple of thoughts

haydenrou · 2025-08-01T13:01:02Z

backend/lib/tasks/app.rake

+      Rake::Task["db:migrate"].invoke
    end
-    Rake::Task["db:structure:load"].invoke
+    #Rake::Task["db:schema:load"].invoke


I'm curious if it would work as intended if we put the db:migrate here, and then the schema:load within the Rails.env.development? block. I'm not sure if this is ran in our deploy process for production anyway, or this is generally just used for development purposes.

haydenrou · 2025-08-01T13:01:11Z

backend/db/migrate/20170817154145_create_positions.rb

      t.string :location_name, null: false
      t.decimal :latitude, {precision: 10, scale: 7}
-      t.decimal :longitude, {precision: 10, scale: 7}
+      #t.decimal :longitude, {precision: 10, scale: 7}


Was this causing a problem?

Probably the migration was failing to go through with the field as is. Can check and confirm.

Finally got around to this. Here is the traceback with the above line not commented out:

== 20170817154145 CreatePositions: migrating ================================== -- create_table(:positions) bin/rails aborted! StandardError: An error has occurred, this and all later migrations canceled: (StandardError) you can't define an already defined column '{:precision=>10, :scale=>7}' on 'positions'. /app/db/migrate/20170817154145_create_positions.rb:7:in `block in change' /app/db/migrate/20170817154145_create_positions.rb:3:in `change' /app/lib/tasks/app.rake:45:in `build_database' /app/lib/tasks/app.rake:32:in `setup' /app/lib/tasks/app.rake:4:in `block (2 levels) in <top (required)>' Caused by: ArgumentError: you can't define an already defined column '{:precision=>10, :scale=>7}' on 'positions'. (ArgumentError) raise ArgumentError, "you can't define an already defined column '#{name}' on '#{@name}'." ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ /app/db/migrate/20170817154145_create_positions.rb:7:in `block in change' /app/db/migrate/20170817154145_create_positions.rb:3:in `change' /app/lib/tasks/app.rake:45:in `build_database' /app/lib/tasks/app.rake:32:in `setup' /app/lib/tasks/app.rake:4:in `block (2 levels) in <top (required)>' Tasks: TOP => db:migrate (See full trace by running task with --trace) make: *** [Makefile:23: seed] Error 1

From what I can tell, it seems that the database for some reason thinks latitude and longtitude are the same field. If it helps, I am using the Docker setup via make build and make seed.

Resolved in 17756c8

compwron · 2025-11-28T02:04:21Z

There's some good stuff in here, rebase and we can merge?

lenikadali · 2025-11-29T19:00:05Z

There's some good stuff in here, rebase and we can merge?

Yes. Will do on Monday 🙌

Changed the line ActiveRecord::Migration to ActiveRecord::Migration[7.1] so that schema loading could work (it is now required for newer versions of Rails) Updated and commented out the load schema task since it fails to find and run the loading of data into the database PostgreSQL container Added the initialize_profile method and add it to the `after_create` portion of the User factory because of the NameError I encountered: NameError: undefined local variable or method `init_profile' for #<FactoryBot::SyntaxRunner:0x00007eaac2e3c560> (NameError)

lenikadali · 2025-12-04T18:48:34Z

There's some good stuff in here, rebase and we can merge?

Yes. Will do on Monday 🙌

Apologies it took longer than I expected to get to this. The branch should now be up to date.

compwron · 2025-12-11T21:27:11Z

lint error in CI

 standard: Use Ruby Standard Style (https://github.com/standardrb/standard)
  db/migrate/20170817154145_create_positions.rb:7:7: Layout/LeadingCommentSpace: Missing space after `#`.
  lib/tasks/app.rake:47:5: Layout/LeadingCommentSpace: Missing space after `#`.
  spec/factories/users.rb:29:1: Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
standard: Run `standardrb --fix`

Copilot

Pull request overview

This PR attempts to upgrade the Rails application from version 5.1 to 7.1 by updating migration version declarations and addressing related compatibility issues. However, the implementation contains several critical errors that would break core functionality.

Updates all ActiveRecord::Migration class declarations from [5.1] to [7.1] across 44 migration files
Attempts to fix a NameError in the User factory by adding profile initialization logic
Modifies the app setup rake task to handle schema/fixtures loading differently

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 3 comments.

File	Description
backend/spec/factories/users.rb	Adds duplicate profile initialization that conflicts with existing User model callback
backend/lib/tasks/app.rake	Incorrectly changes db:fixtures:load to commented db:schema:load
backend/db/migrate/20170817154145_create_positions.rb	Comments out required longitude column, breaking Position model
backend/db/migrate/*.rb (41 files)	Updates migration version from [5.1] to [7.1]

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-11T21:27:40Z

backend/spec/factories/users.rb

+  def initialize_profile
+    create_profile!(
+      checkin_reminder: true,
+      onboarding_step_id: "onboarding-personal",
+      most_recent_doses: {},
+      most_recent_conditions_positions: {},
+      most_recent_symptoms_positions: {},
+      most_recent_treatments_positions: {}
+    )
+  end
+
  factory :user do
    sequence(:email) { |number| "user#{number}@example.com" }
    password { "password123" }
    password_confirmation { "password123" }
+    after(:create) { initialize_profile }


This initialize_profile method and after(:create) callback are unnecessary and will cause issues. The User model already has an after_create :init_profile callback (see backend/app/models/user.rb line 60) that creates the profile with the exact same attributes. This duplicate callback could cause errors or create duplicate profiles. Remove both the initialize_profile method definition and the after(:create) callback from this factory.

Resolved in 235a49a

Copilot · 2025-12-11T21:27:40Z

backend/db/migrate/20170817154145_create_positions.rb

      t.string :location_name, null: false
      t.decimal :latitude, {precision: 10, scale: 7}
-      t.decimal :longitude, {precision: 10, scale: 7}
+      #t.decimal :longitude, {precision: 10, scale: 7}


The longitude column is commented out but it's required by the Position model. The Position model uses self.longitude in the set_location_name callback (backend/app/models/position.rb line 12), and the schema.rb shows this column should exist (backend/db/schema.rb line 76). Commenting out this column will break the Position model functionality and cause database errors. Uncomment this line to match the schema definition.

Resolved in 17756c8

Copilot · 2025-12-11T21:27:40Z

backend/lib/tasks/app.rake

      Rake::Task["db:migrate"].invoke
    end
-    Rake::Task["db:fixtures:load"].invoke
+    #Rake::Task["db:schema:load"].invoke


This change is incorrect and alters the original functionality. The original code invoked db:fixtures:load, but this PR changed it to db:schema:load (which is now commented out). The comment in the PR description mentions issues with schema loading, but the original task was for loading fixtures, not schema. If fixtures loading is failing, that should be investigated and fixed separately. Either restore the original db:fixtures:load invocation or remove the line entirely if fixtures are not needed, rather than changing it to a different commented-out task.

Resolved in c103d87

Reverted changing ActiveRecord::Migration class from [7.1] to [5.1] (this was done as part of the feature branch rebase on master) Also added lint fixes

lenikadali · 2025-12-29T19:06:10Z

lint error in CI

 standard: Use Ruby Standard Style (https://github.com/standardrb/standard)
  db/migrate/20170817154145_create_positions.rb:7:7: Layout/LeadingCommentSpace: Missing space after `#`.
  lib/tasks/app.rake:47:5: Layout/LeadingCommentSpace: Missing space after `#`.
  spec/factories/users.rb:29:1: Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
standard: Run `standardrb --fix`

Resolved in f00f774

Also seeing the same error as the one mentioned in this PR description

Done.

bin/rails aborted!
ActiveModel::UnknownAttributeError: unknown attribute 'checkin_reminder' for Profile. (ActiveModel::UnknownAttributeError)

          raise UnknownAttributeError.new(self, k.to_s)
          ^^^^^
/app/app/models/user.rb:124:in `init_profile'
/app/db/seeds/development/users.seeds.rb:4:in `block in evaluate'
/app/db/seeds/development/users.seeds.rb:3:in `each'
/app/db/seeds/development/users.seeds.rb:3:in `evaluate'
/app/lib/tasks/app.rake:48:in `build_database'
/app/lib/tasks/app.rake:32:in `setup'
/app/lib/tasks/app.rake:4:in `block (2 levels) in <top (required)>'
Tasks: TOP => db:seed => db:seed:development => db:seed:development:users
(See full trace by running task with --trace)

make: *** [Makefile:23: seed] Error 1

Not sure on how exactly to solve it 🤔

Reverted change to fixtures task since going by rubyforgood#789 the original task (`db:structure:load`) has been changed to load fixtures instead.

Removed the `initialize_profile` method and the `after_create` call that uses it since the method may have unforeseen side effects on test setup.

compwron · 2026-01-08T22:59:41Z

this might be fixed, let's see...

compwron · 2026-01-08T23:00:06Z

hmm there are 0 files in this PR now?

lenikadali · 2026-01-09T18:56:56Z

hmm there are 0 files in this PR now?

Yeah it would seem that the changes that were in this PR have been superseded by what is on master \o/
So I'm closing this PR as no longer relevant 🙃

lenikadali commented Mar 10, 2025

View reviewed changes

compwron reviewed Mar 21, 2025

View reviewed changes

haydenrou reviewed Aug 1, 2025

View reviewed changes

lenikadali force-pushed the setup-fixes branch from afe4059 to 6b387ae Compare December 4, 2025 18:47

compwron requested a review from Copilot December 11, 2025 21:24

Copilot started reviewing on behalf of compwron December 11, 2025 21:24 View session

compwron approved these changes Dec 11, 2025

View reviewed changes

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Revert ActiveRecord::Migration class from [7.1] to [5.1]

f00f774

Reverted changing ActiveRecord::Migration class from [7.1] to [5.1] (this was done as part of the feature branch rebase on master) Also added lint fixes

lenikadali added 3 commits December 29, 2025 22:10

Revert change to fixtures task

c103d87

Reverted change to fixtures task since going by rubyforgood#789 the original task (`db:structure:load`) has been changed to load fixtures instead.

Remove initialize_profile, after_create call

235a49a

Removed the `initialize_profile` method and the `after_create` call that uses it since the method may have unforeseen side effects on test setup.

Revert removal of longitude column

17756c8

lenikadali marked this pull request as ready for review December 29, 2025 20:13

lenikadali closed this Jan 9, 2026

Conversation

lenikadali commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lenikadali Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lenikadali Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

compwron left a comment

Choose a reason for hiding this comment

Uh oh!

haydenrou left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

compwron commented Nov 28, 2025

Uh oh!

lenikadali commented Nov 29, 2025

Uh oh!

lenikadali commented Dec 4, 2025

Uh oh!

compwron commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lenikadali commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compwron commented Jan 8, 2026

Uh oh!

compwron commented Jan 8, 2026

Uh oh!

lenikadali commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lenikadali commented Mar 10, 2025 •

edited

Loading

lenikadali Mar 10, 2025 •

edited

Loading

lenikadali Aug 15, 2025 •

edited

Loading

lenikadali commented Dec 29, 2025 •

edited

Loading