Remove legacy name tracking callback from User model#1276
Merged
Conversation
Names are now stored on Person, not User, so the track_name_change callback was firing unnecessarily on User updates. Remove the after_update hook and the track_name_change method. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
track_name_changecallback was firing unnecessarily on User updates, creating misleading Ahoy eventsHow did you approach the change?
after_update :track_name_changecallback fromUsertrack_name_changeprivate methodAnything else to add?
auth.name_changedAhoy events remain in the database but no new ones will be created🤖 Generated with Claude Code