Add interstitial pages for admin email confirmation workflows#1278
Merged
Add interstitial pages for admin email confirmation workflows#1278
Conversation
When an admin changes a user's email, suppress the automatic Devise reconfirmation email and show an interstitial page asking whether to send the confirmation email. When clicking "Confirm email" on the edit page, show an interstitial recommending resend over manual confirm. - Add confirm_email_change and confirm_email_manual interstitial flows - Move pending email banner into identity header on show and edit pages - Replace inline confirm button with link to interstitial page - Rename button labels for clarity (Send reset password email, etc.) - Add ProcessEmailChange and ProcessEmailManualConfirm service objects - Add request and service specs for new endpoints Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace non-existent :confirmed trait with default factory (already sets confirmed_at) - Register new interstitial views in page_bg_class alignment spec Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/email-confirm-interstitials
branch
from
954820c to
e6609d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
How did you approach the change?
ProcessEmailChangeandProcessEmailManualConfirmencapsulate the business logic for each flowAnything else to add?
skip_confirmation_notification!call in the update action is the key Devise hook that suppresses the automatic email🤖 Generated with Claude Code