Add downloadable receipt for paid bulk payments#2011
Open
maebeale wants to merge 3 commits into
Open
Conversation
Bulk payers previously had only an invoice; once a payment is on file they now get a matching paid-in-full receipt from the ticket's Documents section, mirroring the registration receipt flow. The receipt card is locked until a payment is recorded, so the payer sees what unlocks it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/bulk-payment-receipt
branch
from
July 22, 2026 13:41
84961a2 to
318399f
Compare
maebeale
marked this pull request as ready for review
July 22, 2026 13:58
The old comment mostly restated the method body. Keep only the point a reader can't infer: the gate is deliberately looser than the registration receipt's paid-in-full check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
A bulk payment has no owed-balance concept, so its receipt shouldn't borrow the registration receipt's "Total charged / Balance due / Paid in full" framing — it just records whatever was paid. EventReceipt now carries a balance_settlement flag; the shared receipt document shows the reconciliation summary + "Paid in full" badge only when settling a balance (registrations), and a plain "Amount paid" + "Payment received" for bulk payments. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 small backend flow mirroring the existing registration receipt; new presenter method + gated slug route
What is the goal of this PR and why is this important?
How did you approach the change?
EventReceipt.from_bulk_paymentalongside the existingfrom_registration— one itemized line per attendee, the payer's single payment as the ledger entry.EventReceiptnow carries abalance_settlementflag: the shared receipt document shows the "Total charged / Balance due $0 / Paid in full" reconciliation only for registrations, and a plain "Amount paid" + "Payment received" for bulk payments.bulk_payment/:slug/receiptroute/action/policy (direct action onBulkPaymentsController, matching how the registration receipt lives onRegistrationsController), gated onFormSubmission#bulk_payment_receipt_available?(a payment is on file); redirects back to the ticket while pending.events/receipts/_receipt+events/invoices/_actions(print-to-PDF) partials.AllocationLedgerLabelto label aPaymentdirectly (not only via an allocation), so invoice and receipt stay in sync.Ticket integration (rebased onto main's ticket redesign)
short_date_range, "Registrant details"); kept that redesign wholesale.Anything else to add?
from_bulk_payment), request (receipt gating + amount-paid framing + ticket Documents card states), model predicate. Registration receipt path unchanged (still asserts "Paid in full"/"Balance due"). All green; RuboCop clean.