Skip to content

Race Condition Check: spec/system/court_dates/edit_spec.rb #6733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compwron merged 5 commits into from
Feb 25, 2026
+20 −15
Merged

Race Condition Check: spec/system/court_dates/edit_spec.rb #6733

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb59a36
Explicit text values and check for what user sees in the page
stefannibrasil Feb 24, 2026
8c23b17
linter
stefannibrasil Feb 24, 2026
39ee510
Code review request: revert explicit values to variables
stefannibrasil Feb 25, 2026
d2083b1
Remove unused context
stefannibrasil Feb 25, 2026
398eac2
revert back to before
stefannibrasil Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions spec/system/court_dates/edit_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,13 @@
require "rails_helper"

RSpec.describe "court_dates/edit", type: :system do
context "with date"
let(:now) { Date.new(2021, 1, 1) }
let(:organization) { create(:casa_org) }
let(:admin) { create(:casa_admin, casa_org: organization) }
let(:volunteer) { create(:volunteer) }
let(:supervisor) { create(:casa_admin, casa_org: organization) }
let(:supervisor) { create(:supervisor, casa_org: organization) }
let!(:casa_case) { create(:casa_case, casa_org: organization) }
let!(:court_date) { create(:court_date, :with_court_details, casa_case: casa_case, date: now - 1.week) }
let!(:past_court_date) { create(:court_date, :with_court_details, casa_case: casa_case, date: now - 1.week) }
let!(:future_court_date) { create(:court_date, :with_court_details, casa_case: casa_case, date: now + 1.week) }

before do
Expand All @@ -21,12 +20,12 @@
before do
sign_in admin
visit casa_case_path(casa_case)
click_on court_date.date.strftime("%B %-d, %Y")
click_on past_court_date.date.strftime("%B %-d, %Y")
click_on "Edit"
end

it "shows court orders" do
court_order = court_date.case_court_orders.first
court_order = past_court_date.case_court_orders.first

expect(page).to have_text(court_order.text)
expect(page).to have_text(court_order.implementation_status.humanize)
Expand Down Expand Up @@ -66,56 +65,62 @@
within ".top-page-actions" do
click_on "Update"
end

expect(page).to have_text("Court Order Text One")
end

it "can delete a future court date", :js do
it "allows deleting a future court date", :js do
visit root_path
click_on "Cases"
click_on casa_case.case_number

expect(CourtDate.count).to eq 2
expect(page).to have_content past_court_date.date.strftime("%B %-d, %Y")
expect(page).to have_content future_court_date.date.strftime("%B %-d, %Y")
page.find("a", text: future_court_date.date.strftime("%B %-d, %Y")).click
accept_alert "Are you sure?" do
page.find("a", text: "Delete Future Court Date").click
end
expect(page).to have_content "Court date was successfully deleted"
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expected success message is missing a period at the end. The controller at app/controllers/court_dates_controller.rb:58 returns "Court date was successfully deleted." with a period, but this test expects it without one. The supervisor test at line 105 has the correct expectation with the period. This inconsistency should be fixed to match the actual message returned by the controller.

Suggested change
expect(page).to have_content "Court date was successfully deleted"
expect(page).to have_content "Court date was successfully deleted."

Copilot uses AI. Check for mistakes.
expect(CourtDate.count).to eq 1

expect(page).to have_content past_court_date.date.strftime("%B %-d, %Y")
expect(page).not_to have_content future_court_date.date.strftime("%B %-d, %Y")
end
end

context "as a supervisor" do
it "can delete a future court date", :js do
it "allows deleting a future court date", :js do
sign_in supervisor

visit root_path
click_on "Cases"
click_on casa_case.case_number

expect(CourtDate.count).to eq 2
expect(page).to have_content past_court_date.date.strftime("%B %-d, %Y")
expect(page).to have_content future_court_date.date.strftime("%B %-d, %Y")
page.find("a", text: future_court_date.date.strftime("%B %-d, %Y")).click
page.find("a", text: "Delete Future Court Date").click
page.driver.browser.switch_to.alert.accept
accept_alert "Are you sure?" do
page.find("a", text: "Delete Future Court Date").click
end

expect(page).to have_content "Court date was successfully deleted."
expect(CourtDate.count).to eq 1
expect(page).to have_content past_court_date.date.strftime("%B %-d, %Y")
expect(page).not_to have_content future_court_date.date.strftime("%B %-d, %Y")
end
end

context "as a volunteer" do
it "can't delete a future court date as volunteer", :js do
it "does not allow deleting a future court date", :js do
volunteer.casa_cases = [casa_case]
sign_in volunteer

visit root_path
click_on "Cases"
click_on casa_case.case_number

expect(CourtDate.count).to eq 2
expect(page).to have_content past_court_date.date.strftime("%B %-d, %Y")
expect(page).to have_content future_court_date.date.strftime("%B %-d, %Y")
page.find("a", text: future_court_date.date.strftime("%B %-d, %Y")).click

expect(page).not_to have_content "Delete Future Court Date"
end
end
Expand Down
Loading