Repository navigation
Conversation
KoushikSagarr
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
October 30, 2026 03:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Related to #7265
What changed, and why?
This PR brings
spec/models/learning_hours_report_spec.rbinto StandardRB compliance as part of the repository's ongoing gradual StandardRB migration.Previously, this spec was excluded from linting through
.standard_todo.ymldue to aLayout/EmptyLineAfterGuardClauseoffense.The following changes were made:
spec/models/learning_hours_report_spec.rband its associated offense from.standard_todo.yml.next if index.zero?) inside theeach_with_indexblock.This allows the spec to be checked directly by StandardRB instead of remaining in the migration exclusion list.
How is this tested? (please write rspec and jest tests!) 💖💪
The following checks were executed using the project's Docker Compose environment:
StandardRB:
docker compose run --rm web bundle exec standardrb spec/models/learning_hours_report_spec.rb.standard_todo.yml.RSpec:
docker compose run --rm web bundle exec rspec spec/models/learning_hours_report_spec.rbDiff validation:
git diff --checkNo new tests were necessary because this change only addresses formatting and does not alter existing behavior.
Screenshots please :)
Not applicable. This is a Ruby spec formatting and lint-configuration change with no UI modifications.