Repository navigation
Only let volunteers set reminders on their own case contacts - #7274
Merged
Merged
Conversation
Admins and supervisors can still set a followup reminder on any case contact in their org. Volunteers could previously set one on any volunteer's contact in their org; now only on contacts they created. The "Set reminder" button is hidden when the user can't use it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
🧪 Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the org-scoping change in 9fad489.
Before: any volunteer could set a followup reminder on any case contact in their org, including other volunteers' contacts.
After: admins and supervisors can still set one on any case contact in their org, but volunteers only on case contacts they created.
FollowupPolicy#create?now takes the followup record (class-level checks stay role-only)FollowupsController#createauthorizesFollowup.new(case_contact: ...)_reminder_controlhides Set reminder when the user can't use it (e.g. a volunteer viewing another volunteer's contact on a shared case)Tests: new request specs cover another volunteer (refused), a supervisor (allowed) and an admin (allowed) in the same org, and existing followup specs were updated so the volunteer owns the contact. Followup request/policy/system specs and the cross-org spec pass (53 examples).
🤖 Generated with Claude Code