Hide Cancel button for Fullfilled requests#5558
Merged
dorner merged 2 commits intoMay 8, 2026
Merged
Conversation
Cancelling a fulfilled request returns a validation error: "Status cannot be changed once fulfilled". Since fulfilled requests cannot be cancelled, to prevent raising an error, this commit hides the Cancel button for fulfilled requests.
stefannibrasil
changed the title
dorner
approved these changes
May 8, 2026
stefannibrasil
added a commit
to hexdevs/human-essentials
that referenced
this pull request
Jun 1, 2026
This got removed by mistake during the merge. Added originally in rubyforgood#5558
dorner
pushed a commit
that referenced
this pull request
Jun 7, 2026
* Fix typo * Add ability to see cancelled requests The current Requests view does not include cancelled requests. A bank requested that cancelled requests can be listed/exported in this view. When the 'Include Cancelled' field is checked, the view displays cancelled requests. When the field is checked, and the 'Filter by status' field is selected to 'Cancelled', the view lists only cancelled requests. The same is applied to exports. To be consistent with our current wording everywhere else, we are renaming the 'discarded' status to 'cancelled'. Since the DB status column is an integer, renaming it in the enum does not need any work prior to renaming it. * Cancelled requests actions update - Cancelled requests will not have the "cancel" button beside them - Do not show "Fulfil request" -- once a request is cancelled, it is cancelled. - Do not show the "Cancel" button * Ensure cancelled requests cannot have their status changed The UI does not display the buttons to change a cancelled requests' status but adding model validations ensures data integrity. * Create factories only when necessary Small test improvement to only create test data that is needed. * Move system tests to requests System tests are costly to maintain. Leaving just the tests that make more sense to be tested in the browser. * Move more system tests to request specs System tests are costly to maintain. Leaving just the tests that make more sense to be tested in the browser. * Post-merge refactor and address QA feedback After the merge, there were some opportunities to refactor. And after QA, we realized that the 'include cancelled' checkbox is redundant. The new cancelled checkbox as it is not needed now that the cancelled filter works correctly. * Ensure fulfilled requests can't be cancelled This got removed by mistake during the merge. Added originally in #5558
Contributor
|
@stefannibrasil: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5544
Description
Cancelling a fulfilled request returns a validation error: "Status cannot be changed once
fulfilled":
Since fulfilled requests cannot be cancelled, to prevent raising an error, this commit hides the Cancel button for fulfilled requests.
Type of change
How Has This Been Tested?
Locally and with automated tests:
fulfilled requests do not show the Cancel button
another request still shows the Cancel button