Open
Conversation
Fixed initial centering of the QR code in case of large size. Added a QR Code warning if the chosen fixed size is larger than the available display space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request that Closes: #35
A warning message was added if the fixed qr size is too large to be shown in the maximum dimensions of a firefox popup window (800x600), see screenshot 1. This message does not show on mobile platforms . The warning can be dismissed and is automatically hidden if users manually resize the popup.
Furthermore, when trying large fixed sizes to find overflowing QR Codes, I ran into the issue that when the fixed size is large, e.g. 1000, the initial centering of the QR Code is wrong. (screenshot 2)
I was able to fix this by using the resizeLayout function in the initialization.