Draft: Try and switch to Naked Functions#111
Open
thejpster wants to merge 2 commits intorust-embedded:mainfrom
Open
Draft: Try and switch to Naked Functions#111thejpster wants to merge 2 commits intorust-embedded:mainfrom
thejpster wants to merge 2 commits intorust-embedded:mainfrom
Conversation
thejpster
force-pushed
the
naked-functions
branch
from
1704d59 to
5dee966
Compare
jonathanpallant
force-pushed
the
naked-functions
branch
from
488b8c0 to
6bd93f7
Compare
We cannot use this on the main library, because it means we'd need to use the instruction_set attribute (rather than a .arm or .thumb directive) and that isn't available on stable for most of our targets.
jonathanpallant
force-pushed
the
naked-functions
branch
from
6bd93f7 to
f9e7b9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ported everything to naked functions, only to find two issues:
#[instruction_set(arm::xxx)](while you can use.armand.thumbin aglobal_asm!block)So this is draft until MSRV catches up.