Store duration in database #487
Conversation
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
Hi, thank you for the PR! Could you also add code that loads the duration from the DB into the build model? Just so that we can check that the Interval type can be correctly deserialized into Rust.
| @@ -0,0 +1,2 @@ | |||
| -- Add up migration script here | |||
| ALTER TABLE build ADD COLUMN duration INTERVAL; | |||
There was a problem hiding this comment.
Huh, first time I see this (Postgre)SQL data type. Cute.
| }; | ||
|
|
||
| db.update_build_status(&build, status).await?; | ||
| db.update_build_duration(&build, payload.running_time) |
There was a problem hiding this comment.
Let's modify the duration in the db.update_build_status call, to avoid doing two back-to-back SQL queries unnecessarily. I plan to extend the update_build_status function in the near future anyway.
There was a problem hiding this comment.
I was about to add duration in db.update_build_status, but saw this function was used elsewhere which changes only status.
There was a problem hiding this comment.
That's fine, it can just be Option<Duration>.
2 participants
Related to #486
Note:
durationcolumn of thebuildtable for possible future use. Try build duration records should not effect performance, we will filter out only successfully completed auto builds.