Skip to content

internal: Use a generated name in old format_args lowering, instead of args #21263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChayimFriedman2 merged 1 commit into from
Dec 13, 2025
+9 −9
Merged

internal: Use a generated name in old format_args lowering, instead of args #21263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/hir-def/src/expr_store/lower/format_args.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ impl<'db> ExprCollector<'db> {
.collect();
let args =
self.alloc_expr_desugared(Expr::Array(Array::ElementList { elements: args }));
let args_name = Name::new_symbol_root(sym::args);
let args_name = self.generate_new_name();
let args_binding = self.alloc_binding(
args_name.clone(),
BindingAnnotation::Unannotated,
Expand All @@ -674,7 +674,7 @@ impl<'db> ExprCollector<'db> {
} else {
// Generate:
// super let args = (&arg0, &arg1, &...);
let args_name = Name::new_symbol_root(sym::args);
let args_name = self.generate_new_name();
let args_binding = self.alloc_binding(
args_name.clone(),
BindingAnnotation::Unannotated,
Expand Down
14 changes: 7 additions & 7 deletions crates/hir-def/src/expr_store/tests/body.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,24 +278,24 @@ fn main() {
let are = "are";
let count = 10;
{
let args = (&"fancy", &(), &"!", &count, &are, );
let args = [
let <ra@gennew>0 = (&"fancy", &(), &"!", &count, &are, );
let <ra@gennew>0 = [
builtin#lang(Argument::new_display)(
args.3,
<ra@gennew>0.3,
), builtin#lang(Argument::new_display)(
args.0,
<ra@gennew>0.0,
), builtin#lang(Argument::new_debug)(
args.4,
<ra@gennew>0.4,
), builtin#lang(Argument::new_display)(
args.2,
<ra@gennew>0.2,
),
];
unsafe {
builtin#lang(Arguments::new_v1_formatted)(
&[
"\u{1b}hello ", " ", " friends, we ", " ", "",
],
&args,
&<ra@gennew>0,
&[
builtin#lang(Placeholder::new)(
0usize,
Expand Down