Skip to content

update some triage steps, remove requires-incomplete-features #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jieyouxu merged 2 commits into from
Dec 15, 2025
Merged

update some triage steps, remove requires-incomplete-features #986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe785f8
update some triage steps, remove `requires-incomplete-features`
cyrgani Dec 12, 2025
e5d589e
Clarify bisection/MCVE label flips
jieyouxu Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/release/issue-triaging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@ To do the initial triage and remove the `needs-triage` label, the following cond
- Is the issue a regression? If so, apply the `regression-untriaged` label (or figure out what regression it is exactly). Generally speaking, an issue is considered a regression if something used to work, but no longer does.
- If you happen to know people who this issue is relevant to, ping them.
- For example, write `cc @ThatPerson` if `ThatPerson` has been working a lot on the feature in question recently.
- Does this issue require nightly? Add `requires-nightly`.
- Does this issue require incomplete or internal features? Add `requires-{incomplete,internal}-features`.
- Does this issue use any features? Add the corresponding `F-*` label, e.g. `F-const_trait_impl`.
- Does this issue require nightly without using features? Add `requires-nightly`.
- Does this issue require internal features? Add `requires-internal-features`.

### Applying and removing labels

Expand Down Expand Up @@ -106,7 +107,7 @@ There are many different labels that can be applied to issues.
- [`F-*`]: When the issue concerns a specific (usually unstable, usually language) feature.
- [`-Z*`]: When the issue concerns a specific unstable `-Z` compiler flag.
- `requires-nightly`: This issue only affects the nightly channel compiler, and does not affect the beta or stable channel compiler.
- `requires-{incomplete,internal}-features`: This issue requires an incomplete or internal feature. The latter often means that the issue should be closed in accordance with compiler [MCP 620](https://github.com/rust-lang/compiler-team/issues/620).
- `requires-internal-features`: This issue requires an internal feature. This often means that the issue should be closed in accordance with compiler [MCP 620](https://github.com/rust-lang/compiler-team/issues/620).
- [`regression-*`]: Labels for tracking issues that are regressions.
- `regression-untriaged`: The nature and kind of regression is unclear; indicates further regression triage is necessary.
- `regression-from-stable-to-stable`: Something that regressed from an older stable release, which has already reached the latest stable release or even earlier stable releases.
Expand Down Expand Up @@ -219,14 +220,18 @@ For issues that include an Internal Compiler Error (ICE):
- Add `A-*` labels based on the code that causes the issue (check backtraces!), and the nature of the repro (e.g. if the repro is a weird trait impl or the backtrace points to `rustc_trait_selection`, add `A-traits`).
- Add `T-*`, `WG-*`, `PG-*`, `F-*`, `requires-*`, and `regression-*` labels as appropriate.
- Usually the ICE should be tagged `T-compiler`. If the issue concerns the type system (e.g. trait solver), also tag the issue with `T-types`.
- If it is an ICE in rustdoc, add `T-rustdoc` instead of `T-compiler`.
Copy link
Member

@jieyouxu jieyouxu Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: there's a bit of nuance here, in that rustdoc is a rustc_private tool, which means that a root cause can be from the rustc frontend bits. But yes, I agree this is a better label in the general case, at worst the compiler label can be reapplied or adjusted.


## Further triaging

For issues that have been through the initial triaging step (that is, don't have the `needs-triage` label anymore), there are usually still things that can be improved. There are often many more labels that could be applied (using rustbot again if you don't have write access to [`rust-lang/rust`]).

Additionally, old (there is no clear definition of old yet, but something on the order of months) `S-needs-repro` issues can be closed if there is no way to make progress without a reproduction. This requires write access to [`rust-lang/rust`], but if you don't have them, you can just link the issue on Zulip (for example in [`t-release/triage`] or `general`) and someone with write access can close it for you.

Another useful thing to do is to go through `E-needs-mcve` and `E-needs-bisection` issues and create minimizations or bisecting the issue (using [`cargo-bisect-rustc`]). When you provide one, you can also remove the label using rustbot (`@rustbot label -E-needs-bisection`).
Another useful thing to do is to go through `E-needs-mcve` and `E-needs-bisection` issues and create minimizations or bisecting the issue (using [`cargo-bisect-rustc`]).

- When you provide a bisection, adjust the bisection status labels: `@rustbot label -E-needs-bisection +S-has-bisection`.
- When you provide a MCVE, adjust the MCVE status labels: `@rustbot label -E-needs-mcve +S-has-mcve`.

[`rust-lang/rust`]: https://github.com/rust-lang/rust
[URLO]: https://users.rust-lang.org
Expand Down