[WIP] Yet again move some more early buffered lints to dyn lint diagnostics #149984

fmease · 2025-12-14T10:52:25Z

Follow-up to #147634, #145881 and #145747.

TODO: Migrate all 7 remaining rustc_resolve early buffered lints.

fmease · 2025-12-14T13:16:15Z

compiler/rustc_builtin_macros/src/errors.rs

+    pub is_formatting_arg: bool,
+}
+
+impl<'a> LintDiagnostic<'a, ()> for NamedArgumentUsedPositionally {


Could be derived if we did the $ pushing eagerly (might impact perf, unlikely tho).

fmease · 2025-12-14T13:36:21Z

@bors try @rust-timer queue

…try> [WIP] Yet again move some more early buffered lints to dyn lint diagnostics

…gnostics

…t diagnostics

…stics

…try> [WIP] Yet again move some more early buffered lints to dyn lint diagnostics

fmease · 2025-12-14T13:50:38Z

@bors try

rust-bors · 2025-12-14T13:50:47Z

⌛ Trying commit d4a2e3b with merge a2d6150…

(The previously running try build was automatically cancelled.)

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/20208962961

…try> [WIP] Yet again move some more early buffered lints to dyn lint diagnostics

rust-log-analyzer · 2025-12-14T14:28:55Z

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests/ui/rust-2024/reserved-guarded-strings.rs stdout ----
Saved the actual stderr to `/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/rust-2024/reserved-guarded-strings/reserved-guarded-strings.stderr`
diff of stderr:

28 LL |     demo2!(blah#"xx"#);
29    |                ^^^^^^
30    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
32 help: consider inserting whitespace here
33    |
34 LL |     demo2!(blah# "xx"#);

40 LL |     demo2!(## "foo");
41    |            ^^
42    |
-    = note: sequences of two or more # are reserved for future use since Rust 2024
44 help: consider inserting whitespace here
45    |
46 LL |     demo2!(# # "foo");

52 LL |     demo3!("foo"###);
53    |                 ^^
54    |
-    = note: sequences of two or more # are reserved for future use since Rust 2024
56 help: consider inserting whitespace here
57    |
58 LL |     demo3!("foo"# ##);

64 LL |     demo3!(### "foo");
65    |            ^^
66    |
-    = note: sequences of two or more # are reserved for future use since Rust 2024
68 help: consider inserting whitespace here
69    |
70 LL |     demo3!(# ## "foo");

76 LL |     demo3!(## "foo"#);
77    |            ^^
78    |
-    = note: sequences of two or more # are reserved for future use since Rust 2024
80 help: consider inserting whitespace here
81    |
82 LL |     demo3!(# # "foo"#);

88 LL |     demo5!(### "foo"###);
89    |            ^^
90    |
-    = note: sequences of two or more # are reserved for future use since Rust 2024
92 help: consider inserting whitespace here
93    |
94 LL |     demo5!(# ## "foo"###);

100 LL |     demo5!(### "foo"###);
101    |                     ^^
102    |
-    = note: sequences of two or more # are reserved for future use since Rust 2024
104 help: consider inserting whitespace here
105    |
106 LL |     demo5!(### "foo"# ##);

112 LL |     demo1!(#"");
113    |            ^^^
114    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
116 help: consider inserting whitespace here
117    |
118 LL |     demo1!(# "");

124 LL |     demo1!(#""#);
125    |            ^^^^
126    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
128 help: consider inserting whitespace here
129    |
130 LL |     demo1!(# ""#);

136 LL |     demo1!(####"");
137    |            ^^^^^^
138    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
140 help: consider inserting whitespace here
141    |
142 LL |     demo1!(# ###"");

148 LL |     demo1!(#"foo");
149    |            ^^^^^^
150    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
152 help: consider inserting whitespace here
153    |
154 LL |     demo1!(# "foo");

160 LL |     demo1!(###"foo");
161    |            ^^^^^^^^
162    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
164 help: consider inserting whitespace here
165    |
166 LL |     demo1!(# ##"foo");

172 LL |     demo1!(#"foo"#);
173    |            ^^^^^^^
174    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
176 help: consider inserting whitespace here
177    |
178 LL |     demo1!(# "foo"#);

184 LL |     demo1!(###"foo"#);
185    |            ^^^^^^^^^
186    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
188 help: consider inserting whitespace here
189    |
190 LL |     demo1!(# ##"foo"#);

196 LL |     demo1!(###"foo"##);
197    |            ^^^^^^^^^^
198    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
200 help: consider inserting whitespace here
201    |
202 LL |     demo1!(# ##"foo"##);

208 LL |     demo1!(###"foo"###);
209    |            ^^^^^^^^^^^
210    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
212 help: consider inserting whitespace here
213    |
214 LL |     demo1!(# ##"foo"###);

220 LL |     demo2!(#"foo"###);
221    |            ^^^^^^^
222    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
224 help: consider inserting whitespace here
225    |
226 LL |     demo2!(# "foo"###);

232 LL |     demo2!(#"foo"###);
233    |                   ^^
234    |
-    = note: sequences of two or more # are reserved for future use since Rust 2024
236 help: consider inserting whitespace here
237    |
238 LL |     demo2!(#"foo"## #);

244 LL | ...n!(####################################################################################################################################################################################################################################################################"foo");
245    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
246    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
248 help: consider inserting whitespace here
249    |
250 LL |     demon!(# ###################################################################################################################################################################################################################################################################"foo");


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args rust-2024/reserved-guarded-strings.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/rust-2024/reserved-guarded-strings.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/rust-2024/reserved-guarded-strings" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2024"
stdout: none
--- stderr -------------------------------
error: prefix `blah` is unknown
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:44:12
   |
LL |     demo2!(blah"xx"); //~ ERROR prefix `blah` is unknown
   |            ^^^^ unknown prefix
   |
   = note: prefixed identifiers and literals are reserved since Rust 2021
help: consider inserting whitespace here
   |
LL |     demo2!(blah "xx"); //~ ERROR prefix `blah` is unknown
   |                +

error: prefix `blah` is unknown
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:45:12
   |
LL |     demo2!(blah#"xx"#);
   |            ^^^^ unknown prefix
   |
   = note: prefixed identifiers and literals are reserved since Rust 2021
help: consider inserting whitespace here
   |
LL |     demo2!(blah #"xx"#);
   |                +

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:45:16
   |
LL |     demo2!(blah#"xx"#);
   |                ^^^^^^
   |
help: consider inserting whitespace here
   |
LL |     demo2!(blah# "xx"#);
   |                 +

error: reserved multi-hash token is forbidden
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:49:12
   |
LL |     demo2!(## "foo"); //~ ERROR reserved multi-hash token is forbidden
   |            ^^
   |
help: consider inserting whitespace here
   |
LL |     demo2!(# # "foo"); //~ ERROR reserved multi-hash token is forbidden
   |             +

error: reserved multi-hash token is forbidden
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:50:17
   |
LL |     demo3!("foo"###); //~ ERROR reserved multi-hash token is forbidden
   |                 ^^
   |
help: consider inserting whitespace here
   |
LL |     demo3!("foo"# ##); //~ ERROR reserved multi-hash token is forbidden
   |                  +

error: reserved multi-hash token is forbidden
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:51:12
   |
LL |     demo3!(### "foo"); //~ ERROR reserved multi-hash token is forbidden
   |            ^^
   |
help: consider inserting whitespace here
   |
LL |     demo3!(# ## "foo"); //~ ERROR reserved multi-hash token is forbidden
   |             +

error: reserved multi-hash token is forbidden
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:52:12
   |
LL |     demo3!(## "foo"#); //~ ERROR reserved multi-hash token is forbidden
   |            ^^
   |
help: consider inserting whitespace here
   |
LL |     demo3!(# # "foo"#); //~ ERROR reserved multi-hash token is forbidden
   |             +

error: reserved multi-hash token is forbidden
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:53:12
   |
LL |     demo5!(### "foo"###);
   |            ^^
   |
help: consider inserting whitespace here
   |
LL |     demo5!(# ## "foo"###);
   |             +

error: reserved multi-hash token is forbidden
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:53:21
   |
LL |     demo5!(### "foo"###);
   |                     ^^
   |
help: consider inserting whitespace here
   |
LL |     demo5!(### "foo"# ##);
   |                      +

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:57:12
   |
LL |     demo1!(#""); //~ ERROR invalid string literal
   |            ^^^
   |
help: consider inserting whitespace here
   |
LL |     demo1!(# ""); //~ ERROR invalid string literal
   |             +

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:58:12
   |
LL |     demo1!(#""#); //~ ERROR invalid string literal
   |            ^^^^
   |
help: consider inserting whitespace here
   |
LL |     demo1!(# ""#); //~ ERROR invalid string literal
   |             +

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:59:12
   |
LL |     demo1!(####""); //~ ERROR invalid string literal
   |            ^^^^^^
   |
help: consider inserting whitespace here
   |
LL |     demo1!(# ###""); //~ ERROR invalid string literal
   |             +

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:60:12
   |
LL |     demo1!(#"foo"); //~ ERROR invalid string literal
   |            ^^^^^^
   |
help: consider inserting whitespace here
   |
LL |     demo1!(# "foo"); //~ ERROR invalid string literal
   |             +

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:61:12
   |
LL |     demo1!(###"foo"); //~ ERROR invalid string literal
   |            ^^^^^^^^
   |
help: consider inserting whitespace here
   |
LL |     demo1!(# ##"foo"); //~ ERROR invalid string literal
   |             +

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:62:12
   |
LL |     demo1!(#"foo"#); //~ ERROR invalid string literal
   |            ^^^^^^^
   |
help: consider inserting whitespace here
   |
LL |     demo1!(# "foo"#); //~ ERROR invalid string literal
   |             +

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:63:12
   |
LL |     demo1!(###"foo"#); //~ ERROR invalid string literal
   |            ^^^^^^^^^
   |
help: consider inserting whitespace here
   |
LL |     demo1!(# ##"foo"#); //~ ERROR invalid string literal
   |             +

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:64:12
   |
LL |     demo1!(###"foo"##); //~ ERROR invalid string literal
   |            ^^^^^^^^^^
   |
help: consider inserting whitespace here
   |
LL |     demo1!(# ##"foo"##); //~ ERROR invalid string literal
   |             +

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:65:12
   |
LL |     demo1!(###"foo"###); //~ ERROR invalid string literal
   |            ^^^^^^^^^^^
   |
help: consider inserting whitespace here
   |
LL |     demo1!(# ##"foo"###); //~ ERROR invalid string literal
   |             +

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:66:12
   |
LL |     demo2!(#"foo"###);
   |            ^^^^^^^
   |
help: consider inserting whitespace here
   |
LL |     demo2!(# "foo"###);
   |             +

error: reserved multi-hash token is forbidden
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:66:19
   |
LL |     demo2!(#"foo"###);
   |                   ^^
   |
help: consider inserting whitespace here
   |
LL |     demo2!(#"foo"## #);
   |                    +

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings.rs:71:12
   |
LL | ...n!(####################################################################################################################################################################################################################################################################"foo");
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
help: consider inserting whitespace here
   |
LL |     demon!(# ###################################################################################################################################################################################################################################################################"foo");
   |             +

error: aborting due to 21 previous errors
------------------------------------------

---- [ui] tests/ui/rust-2024/reserved-guarded-strings.rs stdout end ----
---- [ui] tests/ui/rust-2024/reserved-guarded-strings-via-macro-2.rs stdout ----
Saved the actual stderr to `/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/rust-2024/reserved-guarded-strings-via-macro-2/reserved-guarded-strings-via-macro-2.stderr`
diff of stderr:

4 LL |     m2024::number_of_tokens_in_a_guarded_string_literal!();
5    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
6    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
8    = note: this error originates in the macro `m2024::number_of_tokens_in_a_guarded_string_literal` (in Nightly builds, run with -Z macro-backtrace for more info)
9 
10 error: invalid string literal

13 LL |     m2024::number_of_tokens_in_a_guarded_unterminated_string_literal!();
14    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
15    |
-    = note: unprefixed guarded string literals are reserved for future use since Rust 2024
17    = note: this error originates in the macro `m2024::number_of_tokens_in_a_guarded_unterminated_string_literal` (in Nightly builds, run with -Z macro-backtrace for more info)
18 
19 error: aborting due to 2 previous errors


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args rust-2024/reserved-guarded-strings-via-macro-2.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/rust-2024/reserved-guarded-strings-via-macro-2.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/rust-2024/reserved-guarded-strings-via-macro-2" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/rust-2024/reserved-guarded-strings-via-macro-2/auxiliary" "--edition=2021" "--extern" "reserved_guarded_strings_macro_2021=/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/rust-2024/reserved-guarded-strings-via-macro-2/auxiliary/libreserved_guarded_strings_macro_2021.so" "--extern" "reserved_guarded_strings_macro_2024=/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/rust-2024/reserved-guarded-strings-via-macro-2/auxiliary/libreserved_guarded_strings_macro_2024.so"
stdout: none
--- stderr -------------------------------
error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings-via-macro-2.rs:14:5
   |
LL |     m2024::number_of_tokens_in_a_guarded_string_literal!();
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the macro `m2024::number_of_tokens_in_a_guarded_string_literal` (in Nightly builds, run with -Z macro-backtrace for more info)

error: invalid string literal
##[error]  --> /checkout/tests/ui/rust-2024/reserved-guarded-strings-via-macro-2.rs:16:5
   |
LL |     m2024::number_of_tokens_in_a_guarded_unterminated_string_literal!();
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the macro `m2024::number_of_tokens_in_a_guarded_unterminated_string_literal` (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 2 previous errors
------------------------------------------

---- [ui] tests/ui/rust-2024/reserved-guarded-strings-via-macro-2.rs stdout end ----

fmease · 2025-12-14T19:18:04Z

@rust-timer build a2d6150

rust-timer · 2025-12-14T19:59:27Z

Finished benchmarking commit (a2d6150): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.5%, secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.5%	[3.5%, 3.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-2.1%	[-2.7%, -1.6%]	3
All ❌✅ (primary)	0.5%	[-2.5%, 3.5%]	2

Cycles

Results (primary 2.2%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.492s -> 480.254s (0.79%)
Artifact size: 390.29 MiB -> 390.25 MiB (-0.01%)

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 14, 2025

fmease commented Dec 14, 2025

View reviewed changes

fmease force-pushed the mv-var-to-dyn-buf-lints-final-ish branch from 33daff4 to 475c181 Compare December 14, 2025 13:35

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Dec 14, 2025

Auto merge of #149984 - fmease:mv-var-to-dyn-buf-lints-final-ish, r=<…

de2117e

…try> [WIP] Yet again move some more early buffered lints to dyn lint diagnostics

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 14, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Dec 14, 2025

Auto merge of #149984 - fmease:mv-var-to-dyn-buf-lints-final-ish, r=<…

9d322e2

…try> [WIP] Yet again move some more early buffered lints to dyn lint diagnostics

rust-lang deleted a comment from rust-bors bot Dec 14, 2025

fmease added 4 commits December 14, 2025 14:49

Move remaining early buffered lints for rustc_parse to dyn lint dia…

601e5b5

…gnostics

Move remaining early buffered lints for rustc_ast_passes to dyn lin…

0f48720

…t diagnostics

Move some more early buffered lints to dyn lint diagnostics

e56df5e

Move more early buffered lints for rustc_resolve to dyn lint diagno…

d4a2e3b

…stics

fmease force-pushed the mv-var-to-dyn-buf-lints-final-ish branch from 475c181 to d4a2e3b Compare December 14, 2025 13:49

rust-bors bot added a commit that referenced this pull request Dec 14, 2025

Auto merge of #149984 - fmease:mv-var-to-dyn-buf-lints-final-ish, r=<…

812a8cc

…try> [WIP] Yet again move some more early buffered lints to dyn lint diagnostics

rust-lang deleted a comment from rust-timer Dec 14, 2025

rust-bors bot added a commit that referenced this pull request Dec 14, 2025

Auto merge of #149984 - fmease:mv-var-to-dyn-buf-lints-final-ish, r=<…

a2d6150

…try> [WIP] Yet again move some more early buffered lints to dyn lint diagnostics

rust-lang deleted a comment from rust-bors bot Dec 14, 2025

fmease removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 14, 2025

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[WIP] Yet again move some more early buffered lints to dyn lint diagnostics #149984

[WIP] Yet again move some more early buffered lints to dyn lint diagnostics #149984

Uh oh!

fmease commented Dec 14, 2025 •

edited

Loading

Uh oh!

fmease Dec 14, 2025

Uh oh!

fmease commented Dec 14, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

fmease commented Dec 14, 2025

Uh oh!

rust-bors bot commented Dec 14, 2025 •

edited

Loading

Uh oh!

rust-log-analyzer commented Dec 14, 2025

Uh oh!

fmease commented Dec 14, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Dec 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

[WIP] Yet again move some more early buffered lints to dyn lint diagnostics #149984

Are you sure you want to change the base?

[WIP] Yet again move some more early buffered lints to dyn lint diagnostics #149984

Uh oh!

Conversation

fmease commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

fmease commented Dec 14, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

fmease commented Dec 14, 2025

Uh oh!

rust-bors bot commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-log-analyzer commented Dec 14, 2025

Uh oh!

fmease commented Dec 14, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Dec 14, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fmease commented Dec 14, 2025 •

edited

Loading

rust-bors bot commented Dec 14, 2025 •

edited

Loading