Skip to content

Conversation

@SATVIKsynopsis
Copy link
Contributor

@SATVIKsynopsis SATVIKsynopsis commented Dec 14, 2025

Fixes #149982.

this pr fixes an ice issue which was there by having multiple default eii implementations. the compiler previously panicked in this situation but now it gives a clear error instead.

also, a ui test is added to cover this case and prevent any implications.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 14, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job pr-check-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
<Nothing changed>
+ reuse --include-submodules lint
# MISSING COPYRIGHT AND LICENSING INFORMATION

The following files have no copyright and licensing information:
* ../e -i HEAD~2


# SUMMARY

* Bad licenses: 0
---


# RECOMMENDATIONS

* Fix missing copyright/licensing information: For one or more files, the tool
  cannot find copyright and/or licensing information. You typically do this by
  adding 'SPDX-FileCopyrightText' and 'SPDX-License-Identifier' tags to each
  file. The tutorial explains additional ways to do this:
  <https://reuse.software/tutorial/>

  local time: Sun Dec 14 17:00:25 UTC 2025
  network time: Sun, 14 Dec 2025 17:00:25 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@jieyouxu
Copy link
Member

I'm not sure if this is just some temporarily placeholder with the intention that it will be eventually supported. If so, in that case, emitting some specific diagnostics doesn't feel necessary, the panic is fine. Not sure about the context, so maybe

r? @jdonszelmann (if available)

@rustbot rustbot assigned jdonszelmann and unassigned jieyouxu Dec 15, 2025
@jdonszelmann
Copy link
Contributor

We likely cannot ever support this, so sure, it's probably alright to make this into a diagnostic not a panic.

@jdonszelmann
Copy link
Contributor

Could you please turn it into a structured diagnostic though like the other ones around here?

@jdonszelmann
Copy link
Contributor

Nooo, wait a second, stop, this isn't what's going on here. There's a deeper bug here. This diagnostic is I guess fine, though there will never be a stable way to achieve this since adding a diagnostic out separated from the declaration won't be something you'd normally do.

The problem is that this won't fix #149982. That code shouldn't get here. Please give me a little bit of time researching that and then we can maybe move forward here. I don't want to accidentally hide an otherwise real bug.

@jdonszelmann
Copy link
Contributor

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2025
@jdonszelmann
Copy link
Contributor

@jieyouxu I'm available for any review surrounding eiis, and probably atm the only one who should given how experimental this one is. If you see more like it feel free to assign me <3

@jdonszelmann
Copy link
Contributor

Oh and this one will have to be squashed in any case fyi

@SATVIKsynopsis
Copy link
Contributor Author

Thanks for the clarification. That makes sense. I agree it would be better not to mask a deeper issue. Happy to wait and help investigate once you have had time to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE eii: multiple annotations

5 participants