Skip to content

gcc backend: remove duplicate handling for max/minimumf128#153447

Closed
RalfJung wants to merge 1 commit intorust-lang:mainfrom
RalfJung:gcc-minmax-dup
Closed

gcc backend: remove duplicate handling for max/minimumf128#153447
RalfJung wants to merge 1 commit intorust-lang:mainfrom
RalfJung:gcc-minmax-dup

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 5, 2026

minimumf128 and maximumf128 are for some reason handled both in get_simple_intrinsic and get_simple_function. Either way they are actually called like functions though, not GCC intrinsics, so let's keep the one one in get_simple_function.

r? @antoyo

@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2026

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 5, 2026
@antoyo
Copy link
Contributor

antoyo commented Mar 5, 2026

Please run the core tests locally to check this change since the CI doesn't run the core tests in here.

@RalfJung
Copy link
Member Author

RalfJung commented Mar 5, 2026

I don't have a setup to run GCC tests. I was hoping CI would take care of that...

@antoyo
Copy link
Contributor

antoyo commented Mar 5, 2026

Unfortunately, the CI here do not run the core tests (it compiles core with LLVM).
Only the CI of the cg_gcc repo runs the core tests.

@RalfJung
Copy link
Member Author

RalfJung commented Mar 5, 2026

Ah, that's good; I will re-send the PR there.

@RalfJung RalfJung closed this Mar 5, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2026
@RalfJung
Copy link
Member Author

RalfJung commented Mar 5, 2026

This code already doesn't exist any more in that repo, it got removed in rust-lang/rustc_codegen_gcc@5b2cfe3 -- seems like there just hasn't been a sync since then.

@RalfJung RalfJung deleted the gcc-minmax-dup branch March 5, 2026 15:59
@antoyo
Copy link
Contributor

antoyo commented Mar 5, 2026

This code already doesn't exist any more in that repo, it got removed in rust-lang/rustc_codegen_gcc@5b2cfe3 -- seems like there just hasn't been a sync since then.

Oh.
The sync is currently blocked on a ThinLTO issue.
I'm currently looking at this with Bjorn: hopefully, that should be fixed in the following days.

@RalfJung
Copy link
Member Author

RalfJung commented Mar 5, 2026

That's a sync in the other direction, but I guess that has to happen first or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants