Skip to content

Refactor query latch#153779

Open
zetanumbers wants to merge 1 commit intorust-lang:mainfrom
zetanumbers:refactor-query-latch
Open

Refactor query latch#153779
zetanumbers wants to merge 1 commit intorust-lang:mainfrom
zetanumbers:refactor-query-latch

Conversation

@zetanumbers
Copy link
Contributor

Removed unnecessary mutex for cycle errors.

Removed unnecessary mutex for cycle errors
@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2026

r? @madsmtm

rustbot has assigned @madsmtm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, query-system
  • compiler, query-system expanded to 69 candidates
  • Random selection from 16 candidates

@zetanumbers
Copy link
Contributor Author

r? @nnethercote

@rustbot rustbot assigned nnethercote and unassigned madsmtm Mar 12, 2026
@Zalathar
Copy link
Member

Could you explain what this change is doing, conceptually?

Right now there’s no way to know what’s going on, other than trying to reverse engineer the textual changes.

@nnethercote
Copy link
Contributor

Could you explain what this change is doing, conceptually?

I was going to ask the same thing. A good rule of thumb is "make life as easy as possible for your reviewer". A bit of context and explanation about the PR helps a lot.

@nnethercote nnethercote added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants