Hand-written Debug implementation for TypeTest#153785
Open
amandasystems wants to merge 1 commit intorust-lang:mainfrom
Open
Hand-written Debug implementation for TypeTest#153785amandasystems wants to merge 1 commit intorust-lang:mainfrom
TypeTest#153785amandasystems wants to merge 1 commit intorust-lang:mainfrom
Conversation
This adds a hand-written debug format for `TypeTest`s that at least was helpful for me when debugging. It formats an type test using the Unicode turnstile symbol (for "computes") to illustrate that the test encodes a typing rule that, if it holds, produces a conclusion.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @madsmtm rustbot has assigned @madsmtm. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Enselic
reviewed
Mar 27, 2026
| /// `InferCtxt::process_registered_region_obligations` and | ||
| /// `InferCtxt::type_must_outlive` in `rustc_infer::infer::InferCtxt`. | ||
| #[derive(Clone, Debug)] | ||
| #[derive(Clone)] |
Member
There was a problem hiding this comment.
For easier comparison, would you mind providing side-by-side comparisons of old vs new output for some illustrative examples, please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a hand-written debug format for
TypeTests that at least was helpful for me when debugging because I always struggle to remember which component is which. It formats a type test using the Unicode turnstile symbol (for "computes") to illustrate that the test encodes a typing rule that, if it holds, produces a conclusion.The format is:
TypeTest from {originating span} {bound} ⊢ T: 'lower_bound, whereTis the generic type being tested andlower_boundis the lower bound. Bounds are formatted as you would expect, but where the region for'lower_boundis included in the outlives constraints for context. I resisted the urge to turnALL [A, ..., Z]into[A ∧ ... ∧ Z]etc.