Skip to content

Split compile tests from run tests#846

Merged
GuillaumeGomez merged 5 commits intorust-lang:masterfrom
GuillaumeGomez:compile-only
Feb 23, 2026
Merged

Split compile tests from run tests#846
GuillaumeGomez merged 5 commits intorust-lang:masterfrom
GuillaumeGomez:compile-only

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jan 29, 2026 •
edited
Loading

Follow-up of #845.

This PR introduces a second step to check that some tests only need to compile.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 30, 2026
Merged
@GuillaumeGomez GuillaumeGomez force-pushed the compile-only branch 2 times, most recently from 9458f58 to 3c61fd8 Compare January 30, 2026 11:13
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 30, 2026

Ah that one is interesting. It means that when I did #841, it didn't check for m68k somehow. There doesn't seem to be a direct translation for __builtin_ia32_pmaxsd128 on m68k though. Gonna ignore this test for this target I think.

@antoyo
Copy link
Contributor

antoyo commented Jan 30, 2026

Ah that one is interesting. It means that when I did #841, it didn't check for m68k somehow. There doesn't seem to be a direct translation for __builtin_ia32_pmaxsd128 on m68k though. Gonna ignore this test for this target I think.

Are you sure it's not a rustc error? In any case, I believe it's OK to ignore it for m68k.

@GuillaumeGomez GuillaumeGomez force-pushed the compile-only branch 4 times, most recently from 0fa1498 to 0893417 Compare January 30, 2026 20:46
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 30, 2026

CI finally passed! \o/

@antoyo
Copy link
Contributor

antoyo commented Feb 21, 2026

Rebasing on master should fix the CI.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Feb 22, 2026

CI passed! \o/

antoyo
antoyo reviewed Feb 22, 2026
View reviewed changes
Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it's going to work?
The lang tests explicitly only run tests from tests/run.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Feb 23, 2026

I removed one too much commit. ^^'

antoyo
antoyo approved these changes Feb 23, 2026
View reviewed changes
Copy link
Contributor

@antoyo antoyo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
One thing to maybe change.

View changes since this review

@GuillaumeGomez GuillaumeGomez merged commit dc273bf into rust-lang:master Feb 23, 2026
38 checks passed
@GuillaumeGomez GuillaumeGomez deleted the compile-only branch February 23, 2026 22:10
@antoyo
Copy link
Contributor

antoyo commented Feb 23, 2026

Thanks for your contribution.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 25, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antoyo antoyo antoyo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuillaumeGomez @antoyo