Change CI to handle openblas MSRV compatibility #1456
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…67 and incompatible with ndarray's MSRV of 1.64
bluss
reviewed
Nov 30, 2024
|
|
||
| Although ``ndarray`` currently maintains an MSRV of 1.64.0, this is separate from the MSRV (either stated or real) of the various BLAS providers. | ||
| As of the time of writing, ``openblas`` currently supports MSRV of 1.67.0. | ||
| So, while ``ndarray`` and ``openblas-src`` are compatible, they can only work together with toolchains 1.67.0 or above. |
Member
There was a problem hiding this comment.
I wonder if ndarray can just use an older blas-src and older openblas-src for earlier Rust. I think that's the case, but I'm not sure we need to use it in CI. Thanks for fixing this
Collaborator
Author
There was a problem hiding this comment.
No problem - I'll try seeing if there's an older openblas-src that we can use and add it to the documentation. But this all was the motivation for #1455, since I was wondering whether we want to bump to 1.67 (in order to make it easier for users to use BLAS)
bluss
approved these changes
Nov 30, 2024
Collaborator
Author
|
Merged as part of #1458 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to BLIS for testing MSRV, since openblas is currently MSRV 1.67 and incompatible with ndarray's MSRV of 1.64