acpi: add support for SRAT #241
Conversation
jellllly420
force-pushed
the
feat/srat
branch
3 times, most recently
from
5c8a0e7 to
fb87df1
Compare
|
I've tested this patch against our project and it seems OK. Now ready for review. |
|
@azongchang I noticed you reviewed this PR while it was still draft. So maybe you are interested in the change? It would be great if you could test it against your need or review it again since it's now marked ready. Thank you. |
jellllly420
force-pushed
the
feat/srat
branch
from
fb87df1 to
c433815
Compare
jellllly420
force-pushed
the
feat/srat
branch
from
c433815 to
5264dd3
Compare
@jellllly420 Thanks for reaching out! I did review the PR earlier because I currently focused on preparing NUMA architecture for a Rust OS. However, I’m still in the early stages of that work, so I won’t be able to test this change comprehensively or provide a detailed review in the near future. |
|
Friendly ping @IsaacWoods. |
|
Friendly ping @IsaacWoods again. :) I need both this PR and the feature from #243 in this PR. Could you please help review #241 and #243? Thanks a lot! |
|
Apologies this has taken so long for a review - irl responsibilities. This was unfortunately opened before the large rewrite, and so both PRs are largely outdated. The approach I'm taking with the new version is markedly different - I have looked at the NUMA bits of the spec and have hashed out the sort of architecture I think would work best re allocations. I will write up the rest of the plumbing tomorrow and open a PR with @jellllly420 as co-author for their contributions so far. Many thanks for your patience. |
4 participants
This PR adds support for System Resource Affinity Table (SRAT) and may fix #46.
I have not tested this patch for correctness so I'll mark it as draft for now.I wrote this patch because we want to acquire the affinity (or topology) information of hardwares to support NUMA platform in our project. Another follow-up PR for System Locality Information Table (SLIT) is on its way.