[Coding Guideline]: Ensure reads of union fields produce valid values #300
+304
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
added new guideline on unions
repaired bibliography
delete unused citations
fixing up bibliography
interim save
manhatsu
force-pushed
the
doc/union-field-validation
branch
from
9dc2bcd to
ea2dcf2
Compare
cleaned up
Collaborator
|
@PLeVasseur @felix91gr I did a final cleanup and this rule LGTM. Please review & approve |
iglesias
reviewed
Dec 16, 2025
Contributor
iglesias
left a comment
iglesias
left a comment
There was a problem hiding this comment.
I left a couple of comments. Otherwise it was all clear. One is a question about a line I wasn't sure about and the other just a typo fix suggestion.
src/coding-guidelines/types-and-traits/gui_UnionFieldValidity.rst.inc
Outdated
Show resolved
Hide resolved
| | *Rust Unsafe Code Guidelines*, n.d. | ||
| | https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#validity-and-safety-invariant. | ||
|
|
||
| >>>>>>> c93b2cb (Update types-and-traits.rst):src/coding-guidelines/types-and-traits.rst |
Contributor
There was a problem hiding this comment.
Can this line be removed? Or is it somehow used as metadata or so?
…rst.inc Co-authored-by: Fernando José <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new guideline on unions by @rcseacord.
This is the same content as #270 but moved to the feature branch.