pkg/analyzer: fix pgx interface method call detection #45
+30,346
−22,032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallabro
force-pushed
the
fix-pgx-interface-method-detection
branch
2 times, most recently
from
15606dd to
8185844
Compare
hallabro
commented
Dec 18, 2025
| github.com/jackc/pgx/v5 v5.5.4 | ||
| github.com/jmoiron/sqlx v1.3.5 | ||
| golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d | ||
| golang.org/x/tools v0.40.0 |
Contributor
Author
There was a problem hiding this comment.
Required for Go 1.25 compatibility, and this in turns bumps Go to 1.24.0.
hallabro
force-pushed
the
fix-pgx-interface-method-detection
branch
from
8185844 to
52a8bc5
Compare
Fix issue ryanrolds#36 where the linter failed to detect missing Close() calls when methods like rows.Next() or rows.Err() were called on pgx.Rows. The root cause was that interface method calls (SSA "invoke mode") were not handled in getAction(). For interface calls, instr.Call.Method is set and StaticCallee() returns nil, causing the code to incorrectly return actionPassed instead of continuing to check for Close(). The fix adds handling for invoke mode at the start of the *ssa.Call case: check if instr.Call.Method is set, verify the receiver is a target type, and return actionClosed for Close() or actionNoOp for other methods like Next(), Err(), and Scan(). Also updates golang.org/x/tools for Go 1.25 compatibility.
hallabro
force-pushed
the
fix-pgx-interface-method-detection
branch
from
52a8bc5 to
c6d65a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #36 where the linter failed to detect missing
Close()calls when methods likerows.Next()orrows.Err()were called onpgx.Rows.The fix adds handling for invoke mode at the start of the
*ssa.Callcase.I tested it out on a local project and it seems to properly detect missing calls to
Close.Let me know what you think.