Skip to content

@W-21771476: feat: display HasVpi in package version list and report commands [DO NOT MERGE until 6/4 262.8 deploy]#1213

Open
tporcaro-sf wants to merge 2 commits into
mainfrom
t/managed-packaging/w-21771476/display-hasvpi-field-in-package-version-commands
Open

@W-21771476: feat: display HasVpi in package version list and report commands [DO NOT MERGE until 6/4 262.8 deploy]#1213
tporcaro-sf wants to merge 2 commits into
mainfrom
t/managed-packaging/w-21771476/display-hasvpi-field-in-package-version-commands

Conversation

@tporcaro-sf
Copy link
Copy Markdown
Collaborator

@W-21771476@

Summary

  • Display HasVpi field in sf package version list --verbose and sf package version report
  • Version-gated at API v67+ (column/row absent at lower versions)
  • List displays 'true'/'false'/'N/A' (unlocked); Report displays 'Yes'/'No'/'N/A'
  • JSON schemas updated

Dependencies

  • Requires forcedotcom/packaging#875 to merge first (publishes new @salesforce/packaging version)
  • Requires W-21771475 (262.8 patch) to be fully deployed (scheduled 6/4)
  • After packaging merges, this PR needs a dep bump commit before merge

Test plan

  • Unit tests: report massage transforms (managed→Yes, unlocked→N/A, undefined stays undefined)
  • Schema validation passing
  • NUT: HasVpi key present in verbose json output (conditional on org API version)
  • Manual testing on 262 devhub (hub0318) and 260 devhub (hub1215)

🤖 Generated with Claude Code

@tporcaro-sf tporcaro-sf requested a review from a team as a code owner June 2, 2026 17:30
@salesforce-cla
Copy link
Copy Markdown

salesforce-cla Bot commented Jun 2, 2026

Thanks for the contribution! It looks like @tjporcaro is an internal user so signing the CLA is not required. However, we need to confirm this.

@tporcaro-sf tporcaro-sf force-pushed the t/managed-packaging/w-21771476/display-hasvpi-field-in-package-version-commands branch from d555757 to 67ebfde Compare June 2, 2026 17:38
@tporcaro-sf tporcaro-sf requested review from KSCCO and shetzel June 2, 2026 17:41
@tporcaro-sf
Copy link
Copy Markdown
Collaborator Author

tporcaro-sf commented Jun 2, 2026

⚠️ CI compile failure is expected@salesforce/packaging on npm doesn't have the HasVpi type yet.

Once forcedotcom/packaging#875 merges and publishes, I'll bump the dep here and CI will go green.

cc: @KSCCO @shetzel

@tporcaro-sf
Copy link
Copy Markdown
Collaborator Author

tporcaro-sf commented Jun 2, 2026

Screenshot 2026-06-02 at 2 04 08 PM Screenshot 2026-06-02 at 2 09 01 PM

Note: "Has Version Settings" label reviewed/approved by Joanna Nolasco

cc: @KSCCO @shetzel

@KSCCO
Copy link
Copy Markdown
Collaborator

KSCCO commented Jun 2, 2026

It seems inconsistent that list returns true/false and report returns yes/no. Is there a reason for that?

@tporcaro-sf
Copy link
Copy Markdown
Collaborator Author

It seems inconsistent that list returns true/false and report returns yes/no. Is there a reason for that?

@KSCCO No Solid reason. I think it was to make it consistent with Managed Metadata Removed: Yes/No in the report. But other fields in the report like Code Coverage Met: use true/false so it seems we can do that instead and be consistent between the list and the report. I'll make the change.

@tporcaro-sf
Copy link
Copy Markdown
Collaborator Author

tporcaro-sf commented Jun 2, 2026

@KSCCO Updated — report now displays true/false (consistent with list and Code Coverage Met). See commit e9a8849.

Screenshot 2026-06-02 at 5 41 11 PM

@tporcaro-sf tporcaro-sf force-pushed the t/managed-packaging/w-21771476/display-hasvpi-field-in-package-version-commands branch from e9a8849 to 4b34f67 Compare June 2, 2026 23:44
Copy link
Copy Markdown
Collaborator

@KSCCO KSCCO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Is all the reformatting in package-version-report.json intended? I don't know what the style guidelines are.

@tporcaro-sf
Copy link
Copy Markdown
Collaborator Author

tporcaro-sf commented Jun 3, 2026

@KSCCO Yes — prettier reformatted the schema file when it was touched by the pre-commit hook. The only functional change is the addition of the HasVpi property at the end. The rest is prettier collapsing multi-line arrays to single lines (e.g., "type": [\n "boolean",\n "string"\n]"type": ["boolean", "string"]).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants