Repository navigation
Add NEON tests the test/entropy program. - #160
Open
jkbonfield wants to merge 1 commit into
Open
jkbonfield wants to merge 1 commit into
jkbonfield wants to merge 1 commit into
Conversation
daviesrob
reviewed
Nov 12, 2026
| # Four copies tests the large buffer histogram variant | ||
| cat $srcdir/dat/q4 $srcdir/dat/q4 $srcdir/dat/q4 $srcdir/dat/q4 | ./entropy | ||
| # Large buffer testing | ||
| gzcat $srcdir/dat/entropy4.gz | (ulimit -s 64; ./entropy) |
Member
There was a problem hiding this comment.
daviesrob
reviewed
Nov 12, 2026
daviesrob
left a comment
daviesrob
left a comment
Member
There was a problem hiding this comment.
A small change is needed to the ulimit to prevent failures on ASAN builds.
Neon is -c 0x0808, but we only tested from 0000 to 0404. (On x86 this doesn't matter - it'll just be a scalar test, just as the AVX ones on NEON are too.) Signed-off-by: James Bonfield <jkb@sanger.ac.uk>
jkbonfield
force-pushed
the
neon-tests
branch
from
November 12, 2026 14:24
33d0baf to
f7ebe32
Compare
Collaborator
Author
Adjusted it to -s 128. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neon is -c 0x0808, but we only tested from 0000 to 0404. (On x86 this doesn't matter - it'll just be a scalar test, just as the AVX ones on NEON are too.)
Also use
ulimit -sinstead ofsetrlimitas it appears the Mac may ignore some aspects of this, invalidating the stack size checks.A companion to #159 which this change is designed to validate the error prior to fixing it, and to ensure we're checking everything we believed we were.