GFD-2481 model engine internal CVE remediation#838
Open
astringel wants to merge 3 commits into
Open
Conversation
…remediation - aws-iam-authenticator v0.5.9 → v0.7.11 (CVE-2026-39823, CVE-2026-39825, CVE-2026-39826, CVE-2026-42504): the old binary embedded Go 1.17/1.18 stdlib with known HIGH vulnerabilities; v0.7.11 ships a newer toolchain. - mako 1.2.4 → 1.3.11 (CVE-2026-41205): patch upgrade to the fixed release. - Chainguard base image cgr.dev/scale.com/python-fips:3.10.19-dev → :3.10-dev (floating latest 3.10 tag): no newer exact pin found in local files; using floating tag to pull the most current patched base at build time, addressing libgnutls30, linux-libc-dev, libpython3.11, libcap2, openssh, and libkrb5 CVE groups via OS package tree replacement.
The floating 3.10-dev tag is non-reproducible and does not satisfy the pinned-tag requirement in the GFD-2481 CVE remediation spec. Pin to 3.10.20-r7-dev, confirmed as the latest -dev tag via crane ls on 2026-06-10. The -dev variant is retained because Dockerfile.fips installs build tools at image build time.
Dockerfile.fips: verify the downloaded binary's SHA256 against the upstream checksums before making it executable, so a compromised release asset or CDN cache-poisoning event fails the build rather than silently landing in the FIPS image. .gitlab-ci.yml: pin both scalegov2-pipelines includes to a specific commit SHA instead of the floating ref: main, giving the pipeline a stable, auditable baseline.
516595c to
a3c55e0
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Review feedbackVerified the security-critical pieces against upstream — the core change (base-image re-pin + Verified
Non-blocking notes
Gate before merge (from the test plan)
|
billyang-scale
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remediates 3 Critical and 34 High severity Trivy CVEs in the apps/model-engine-internal FIPS image (ipv4-pr758-61262d88-amd64), the single largest CVE contributor in the June 9 net-new scan (214 total Critical+High findings across dev, FedRAMP prod, IL5 prod, and shared-inference).
Changes:
Test Plan and Usage Guide
Greptile Summary
This PR is a targeted CVE remediation for the
model-engine-internalFIPS image, bumping the Chainguard base image, upgradingaws-iam-authenticator, and updating a Python dependency.Dockerfile.fips: Base image promoted from3.10.19-devto3.10.20-r7-dev(replacing vulnerable Debian OS packages with patched Alpine equivalents);aws-iam-authenticatorupgraded from v0.5.9 → v0.7.11 and a SHA256 digest check now guards the download — the supply-chain gap flagged in the previous review has been addressed.requirements.txt:makobumped from 1.2.4 → 1.3.12 (resolves CVE-2026-41205);legacy-cgi==2.6.4pinned as a new transitive dependency pulled in byddtrace.Confidence Score: 5/5
Safe to merge once CI confirms the Dockerfile builds successfully and the post-build Trivy scan clears.
All changes are version bumps with no functional logic changes. The previously missing binary integrity check is now in place — if the SHA256 digest in the Dockerfile is wrong the build fails fast rather than silently accepting an untrusted binary. The base image and Python dependency changes are straightforward package upgrades with no cross-cutting side effects.
No files require special attention; both changed files contain only version bumps.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["FROM cgr.dev/scale.com/python-fips:3.10.20-r7-dev\n(was 3.10.19-dev)"] --> B[apk add build deps] B --> C["curl aws-iam-authenticator v0.7.11\n(was v0.5.9)"] C --> D["sha256sum -c verification\n(NEW — fails build on mismatch)"] D -->|"hash OK"| E[chmod +x binary] D -->|"hash mismatch"| F[❌ Build aborted] E --> G[pip install pip==24.2] G --> H[pip install awscli==1.34.28] H --> I["pip install requirements.txt\n(mako==1.3.12, legacy-cgi==2.6.4)"] I --> J[EXPOSE 5000 / USER nonroot]Reviews (4): Last reviewed commit: "Verify aws-iam-authenticator digest and ..." | Re-trigger Greptile