Skip to content

[Fix] Accept proof submission even it has been timeout #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noel2004 merged 7 commits into from
Dec 12, 2025
Merged

[Fix] Accept proof submission even it has been timeout #1764

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e1e5278
accept timeout submission
noel2004 Nov 25, 2025
d19a3fb
Merge remote-tracking branch 'origin/develop' into fix/accept_timeout…
noel2004 Nov 26, 2025
ab46c98
Merge remote-tracking branch 'origin/develop' into fix/accept_timeout…
noel2004 Dec 1, 2025
8344914
Merge remote-tracking branch 'origin/develop' into fix/accept_timeout…
noel2004 Dec 8, 2025
055f76e
Fixing and handling unexpected return routine
noel2004 Dec 11, 2025
1e85070
Keep failure type in close task
noel2004 Dec 11, 2025
1347762
purge stuffs commited by mistake
noel2004 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions coordinator/internal/logic/submitproof/proof_receiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,14 +346,6 @@ func (m *ProofReceiverLogic) validator(ctx context.Context, proverTask *orm.Prov
return ErrValidatorFailureProofMsgStatusNotOk
}

// if prover task FailureType is SessionInfoFailureTimeout, the submit proof is timeout, need skip it
if types.ProverTaskFailureType(proverTask.FailureType) == types.ProverTaskFailureTypeTimeout {
m.validateFailureProverTaskTimeout.Inc()
log.Info("proof submit proof have timeout, skip this submit proof", "hash", proofParameter.TaskID, "taskType", proverTask.TaskType,
"proverName", proverTask.ProverName, "proverPublicKey", pk, "proofTime", proofTimeSec)
return ErrValidatorFailureProofTimeout
}

// store the proof to prover task
if updateTaskProofErr := m.updateProverTaskProof(ctx, proverTask, proofParameter); updateTaskProofErr != nil {
log.Warn("update prover task proof failure", "hash", proofParameter.TaskID, "proverPublicKey", pk,
Expand All @@ -368,6 +360,14 @@ func (m *ProofReceiverLogic) validator(ctx context.Context, proverTask *orm.Prov
"taskType", proverTask.TaskType, "proverName", proverTask.ProverName, "proverPublicKey", pk)
return ErrValidatorFailureTaskHaveVerifiedSuccess
}

// if prover task FailureType is SessionInfoFailureTimeout, the submit proof is timeout, but we still accept it
if types.ProverTaskFailureType(proverTask.FailureType) == types.ProverTaskFailureTypeTimeout {
m.validateFailureProverTaskTimeout.Inc()
log.Warn("proof submit proof have timeout", "hash", proofParameter.TaskID, "taskType", proverTask.TaskType,
"proverName", proverTask.ProverName, "proverPublicKey", pk, "proofTime", proofTimeSec)
}

return nil
}

Expand Down
Loading