Zb/illico threads#4205
Open
zboldyga wants to merge 6 commits into
Open
Conversation
…on_illico Pass settings.n_jobs to illico.asymptotic_wilcoxon (was defaulting to 1 thread, ~12x slower than possible). Document the wilcoxon_illico method, correct the corr_method/tie_correct/logfoldchanges docstrings, and include non-logreg methods in the finished-log message.
…or. wrap illico call so numba config setting is properly restored on completion (so no side effects on thread value from illico)
Contributor
Author
|
@ilan-gold while not high impact, I also saw some inconsistencies with the way n_jobs is used throughout scanpy. I preferred not to open that can of worms here. Might just be something that is most easily solved with clear docs in each use case anyway. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4205 +/- ##
==========================================
- Coverage 79.90% 79.88% -0.02%
==========================================
Files 121 121
Lines 12949 12958 +9
==========================================
+ Hits 10347 10352 +5
- Misses 2602 2606 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ilan-gold this is a small PR that does a few things: