-
Notifications
You must be signed in to change notification settings - Fork 52
Parse entire macsima metadata from OME metadata #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
- Coverage 55.07% 52.81% -2.27%
==========================================
Files 26 26
Lines 2809 2969 +160
==========================================
+ Hits 1547 1568 +21
- Misses 1262 1401 +139
🚀 New features to boost your workflow:
|
|
I checked the tests and the failing ones are all due to some Xenium and Visium HD readers, which I didnt touch XD Did they exist before this PR already? |
|
Hey everyone, I implemented 2 versions of the parser, as there are 2 different formats of the metadata. I removed the previously used data sets, as they are not part of the CI. Instead, I added 2 publicly available data sets, one for each version. I tried modifying the github action to download them, but it seems that this was not really successful. If someone can give me some pointers that would be wonderful. Cheers! |
|
Hi @MSHelm, thanks for the contribution! I’ve fixed the unrelated failing tests on main, and your PR is now green. I had a quick look but before full review I kindly ask you to verify and confirm which items from the contribution guide checklist apply to this PR. Ensuring the contributions guidelines are followed help streamline our review process and improve long-term code maintainability. Much appreciated! |
Fixes #348
The parser now tries to use the filename stored in the tiff metadata, if it exists. This is more robust, as users typically do not modify these entries.
If this metadata doesnt exist (which is the case for older data), it falls back to the actual filename.
Since the lung dataset used for testing is using an old format, I added a newer data set that is publicy available (https://zenodo.org/records/14008816). I documented this in the tests as well.
Full disclosure: I am working for Miltenyi, but I love your work ;)