Rework PAMM#850
Draft
fabianbs96 wants to merge 19 commits into
Draft
Conversation
… to work with (getting the string names right, ...)
…nstantiation to improve compile-times
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Performance Measurement Meachanism (PAMM) is old, slow, and cumbersome to use. It is not thread-safe and heavily relies on macros.
This PR reworks PAMM to use templates for achieving zero-overhead counters, timers, and histograms. Also unit-tests and PAMM are no longer mutually exclusive.
All new PAMM entities are in the namespace
par::pamm.New PAMM counters, etc. are scoped! Define a
PAMM_CATEGORY("name");in a scope (type or namespace) to create a new category. All pamm entities in that scope that can see the category will pick it up automatically.Use the new
PAMM_macros to declare counters, etc. as static variables (no longer identifying pamm entities via strings!). They are registered automatically in the globalpamm::Registry. To increment a counter, adding datapoints to a histogram etc. directly access the declared static variable.For reference how to use the new PAMM, look at the
IDESolver.