Skip to content

Conversation

@agouveia-twilio
Copy link

Introduces a new 'subscription_groups' field to manage user subscription status for specific groups in both updateUserProfile and updateUserProfile2 actions. Updates type definitions, action schemas, and utility functions to handle this new attribute.

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

Introduces a new 'subscription_groups' field to manage user subscription status for specific groups in both updateUserProfile and updateUserProfile2 actions. Updates type definitions, action schemas, and utility functions to handle this new attribute.
subscription_groups: {
label: 'Subscription Groups',
description: 'Array of objects used to manage a user\'s subscription status for specific subscription groups.',
type: 'object',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add defaultObjectUI here to make the new field show key value pairs by default.

},
subscription_groups: {
label: 'Subscription Groups',
description: 'Array of objects used to manage a user\'s subscription status for specific subscription groups.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could link to Braze docs where customers can learn more.

@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Dec 8, 2025

Hi @agouveia-twilio thanks for the PR.

The change looks pretty straightforward, but there's a little more that needs to be done though before we can deploy it.

We need to ensure that what gets deployed works for all customers, and not just for the customer you are working with.

With that in mind please review the below:

  1. Have we delivered what customers expect? Have we done enough?
  • should other actions also include this functionality? identify() for example?
  • should email / push subscription details also be included in the track() actions?
  • isn't there a global subscription switch in Braze which turns off / on all subscriptions regardless of subscription groups?
  1. Please provide proof that the Braze API can accept these new values. e.g. links to docs and screenshots / excerpts from the docs showing how the payload should be formatted to include subjscription details.

  2. Add unit tests to the tests.ts files which specifically cover the new fields.

  3. Make sure no other unit tests break.

  4. Show proof of testing. i.e screenshots of video showing data being sent from Segment to Braze, with the Braze UI showing the correct outcome of the change.

  5. Confirm if any other Segment <> Braze Destination already has this functionality or not - show how it works - and explain how the implemenation in this PR is different / similar. We want to ensure a consistant customer experience where possible.

If you need help with any of this please reach out and we can jump on a call. But see what you can get done by yourself and we can go from there.

Cheers,
Joe

@joe-ayoub-segment joe-ayoub-segment changed the title Add subscription group support to Braze user profile STRATCONN-6410 - [Braze] - Add subscription group support to Braze user profile Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants