-
Notifications
You must be signed in to change notification settings - Fork 294
STRATCONN-6410 - [Braze] - Add subscription group support to Braze user profile #3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Introduces a new 'subscription_groups' field to manage user subscription status for specific groups in both updateUserProfile and updateUserProfile2 actions. Updates type definitions, action schemas, and utility functions to handle this new attribute.
| subscription_groups: { | ||
| label: 'Subscription Groups', | ||
| description: 'Array of objects used to manage a user\'s subscription status for specific subscription groups.', | ||
| type: 'object', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add defaultObjectUI here to make the new field show key value pairs by default.
| }, | ||
| subscription_groups: { | ||
| label: 'Subscription Groups', | ||
| description: 'Array of objects used to manage a user\'s subscription status for specific subscription groups.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could link to Braze docs where customers can learn more.
|
Hi @agouveia-twilio thanks for the PR. The change looks pretty straightforward, but there's a little more that needs to be done though before we can deploy it. We need to ensure that what gets deployed works for all customers, and not just for the customer you are working with. With that in mind please review the below:
If you need help with any of this please reach out and we can jump on a call. But see what you can get done by yourself and we can go from there. Cheers, |
Introduces a new 'subscription_groups' field to manage user subscription status for specific groups in both updateUserProfile and updateUserProfile2 actions. Updates type definitions, action schemas, and utility functions to handle this new attribute.
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'