Skip to content

Conversation

@nk1107
Copy link
Contributor

@nk1107 nk1107 commented Dec 8, 2025

This change adds multistatus support to the-tradedesk-crm action destination. This change is done to support observability changes. The framework validates the the emails in the payloads and drops the payloads with invalid emaild ids. Multistatus is used to track all the dropped events.

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Testing Stage

image

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.00%. Comparing base (b1e555e) to head (8623abc).

Files with missing lines Patch % Lines
...s/src/destinations/the-trade-desk-crm/functions.ts 61.53% 10 Missing ⚠️

❌ Your patch check has failed because the patch coverage (61.53%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3456      +/-   ##
==========================================
- Coverage   80.02%   80.00%   -0.03%     
==========================================
  Files        1226     1226              
  Lines       22768    22786      +18     
  Branches     4526     4528       +2     
==========================================
+ Hits        18221    18230       +9     
- Misses       3711     3720       +9     
  Partials      836      836              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants