avoid taking snapshot upon StateDB creation #2787
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
We used to take a Snapshot of the store whenever an EVM transaction starts, even if it's just a value transfer, because we need the original context to serve
GetCommittedState. Taking snapshot is expensive from an allocation standpoint. This PR adds a new method oncachekv.Storeso that for giga,GetCommittedStatecan invoke the new method instead of having to take a snapshot at the beginning.Testing performed to validate your change
unit tests