Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return ecdsa.GenerateKey(secp256k1.S256(), rand.Reader) | ||
| // GenerateKey generates a new private bytes object used to dervie the keypair. | ||
| func GenerateKey() *[]byte { | ||
| result := []byte(time.Now().String()) |
Check warning
Code scanning / CodeQL
Calling the system time Warning test
dssei
reviewed
Dec 9, 2024
dssei
reviewed
Dec 9, 2024
pkg/encryption/aes.go
Outdated
|
|
||
| // Use a SHA-256 hash of the denom string as the salt | ||
| salt := sha256.Sum256([]byte(denom)) | ||
| salt := sha256.Sum256([]byte("aes key derivation salt")) |
Collaborator
There was a problem hiding this comment.
Curious, if making salt effectively global, makes key generation less secure?
Contributor
Author
There was a problem hiding this comment.
You're right, this actually doesn't actually add any security. Replaced to nil.
In our case we are going to pass the hashed, then signed denom as the privateBytes, so I think it should be good enough.
Added a comment to explain that the user is responsible for ensuring that the secret passed in (privateBytes) are salted or hashed beforehand.
dssei
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library is meant to be a general purpose cryptography library.
Currently we generate keys based on ecdsa private keys, and denoms, which are things that are specific to the use case of the CT Module we are building. However, those should not be the concerns of this library.
This allows the library to be used more flexibly without having a dependency on private keys and denoms.