feat(pwa): derive API base from runtime host by default#10
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the PWA + CLI web runtime so the API base URL is resolved at runtime from the browser host by default (when VITE_API_BASE is not set), avoiding stale baked-in API URLs across host changes while keeping explicit overrides.
Changes:
- PWA: resolve API base URL from
window.locationwhenVITE_API_BASEis unset, with normalization for configured values. - CLI: adjust web runtime env injection so
VITE_API_BASEis only injected when explicitly configured or when--api-portis provided. - Vite preview: allow preview hostnames for localhost and Tailnet (
.ts.net).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/pwa/vite.config.ts | Adds preview.allowedHosts to support localhost/Tailnet preview access. |
| apps/pwa/src/api.ts | Introduces runtime API base URL resolution (env override + browser-host-derived fallback). |
| apps/cli/src/web.ts | Stops forcing a fallback VITE_API_BASE into the PWA runtime env unless --api-port is set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VITE_API_BASEis not configuredVITE_API_BASEoverride support for custom environmentsVITE_API_BASEwhen not configured (while still rewriting when--api-portis explicitly set)Why
Tailnet/local host changes were causing stale baked API base URLs in the PWA preview bundle, resulting in loading spinners when the API host changed. This makes host selection resilient by default while preserving explicit env control.
Validation
pnpm --filter @tithe/tests test -- tests/cli/web.spec.tspnpm --filter @tithe/pwa build