Open
Conversation
* Update config Added map_parameters to config and set to null to avoid error when being parsed. Updated FlightAware AeroAPI info to reflect current information. * Corrected typo Corrected typo caused by accidental deletion of characters in a comment. * Edited FlightAware API comment Corrected grammar of the FlightAware API comment.
The runbot.sh script attempts to remove nohup.out without checking whether it exists first which can cause a warning/error. THis change adds logic to only attempt to delete the file if it exists. Also adds a variable that can be used to indicate if nohup.out is desired without having to comment/uncomment lines.
Add logic for nohup.out deletion to runbot.sh
- Selenium 4.3.0 deprecated the find_element(s)_xxx commands causing exceptions for installs with the new version. This change adds support for the 4.3.0 commands while retaining support for older installs of Selenium. It does not add any new functionality from 4.3.0. - In ClickOnAirplane, aircraft rows were found by looking for the hex value in \<td\>. The hex column isn't displayed by default in tar1090, however, which causes an error when trying to find the aircraft. Changed it to look at the id in \<tr\> which is always available.
Add support for Selenium 4.3.0, Correct ClickOnAirplane issue
The original code is looking for "speed" in the aircraft.json file, but dump1090-fa uses "gs" (ground speed) instead. Added check for "gs" to allow speed to be reported for dump1090-fa users. This same fix was submitted to OverPutney by derektgardner (Update flightdata.py shbisson#9)
Update flightdata.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update config
Added map_parameters to config and set to null to avoid error when being parsed.
Updated FlightAware AeroAPI info to reflect current information.
Edited FlightAware API comment
Tweaked the working of the FlightAware API comment.