fix: scope workflow commits to defined commit points - #177
Merged
Merged
Conversation
The build and implement recipes declared the 4-step task cycle as MANDATORY without stating its scope, and phrased the quality gate as "run quality-fixer before every commit". Together these read as "a quality-fixer pass means commit", so the post-implementation review loop generated one commit per findings round even though no rule requires it. - Scope the mandatory 4-step cycle to the Consumed Task Set, and state that corrections outside it reuse the executor-result branching and quality gate while deferring only the commit - Replace "run quality-fixer before every commit" with the positive precondition: commit only after approved or verification_incomplete - Fix-cycle handoff: keep post-implementation corrections uncommitted; reviewers read the working tree, and applied corrections are committed once at Review Resolution convergence - Fix-cycle handoff: route executor-owned corrections through the per-task cycle's step 2 so the conditional integration-test-reviewer path is not skipped - Final Cleanup: make the pre-cleanup commit an explicit step instead of an assumption - Bump plugin versions to 0.25.6 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The build and implement recipes declared the 4-step task cycle as
MANDATORYwithout stating its scope, and phrased the quality gate as "run quality-fixer before every commit". Read together, those became "a quality-fixer pass means commit", so the post-implementation review loop produced one commit per findings round.No rule required that. Commits are mandated only at the per-task cycle's step 4, the retained-verification retry, and implicitly before Final Cleanup.
code-reviewertakesimplementationFilespaths and reads the working tree, so review does not need committed state either.Changes
approvedorverification_incompleteintegration-test-reviewerpath is not skipped when a correction changes integration/E2E testsFiles:
recipe-build,recipe-front-build,recipe-implement,recipe-fullstack-implement,subagents-orchestration-guide, synced to the three plugin directories.Verification
node scripts/sync-plugins.mjs --check— in syncclaude plugin validate— marketplace and all four plugins pass🤖 Generated with Claude Code