Skip to content

fix: scope workflow commits to defined commit points - #177

Merged
shinpr merged 1 commit into
mainfrom
fix/scope-review-loop-commits
Sep 7, 2026
Merged

shinpr merged 1 commit into
mainfrom
fix/scope-review-loop-commits

Conversation

@shinpr

@shinpr shinpr commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Problem

The build and implement recipes declared the 4-step task cycle as MANDATORY without stating its scope, and phrased the quality gate as "run quality-fixer before every commit". Read together, those became "a quality-fixer pass means commit", so the post-implementation review loop produced one commit per findings round.

No rule required that. Commits are mandated only at the per-task cycle's step 4, the retained-verification retry, and implicitly before Final Cleanup. code-reviewer takes implementationFiles paths and reads the working tree, so review does not need committed state either.

Changes

  • Scope the mandatory 4-step cycle to the Consumed Task Set, and state that corrections outside it reuse the executor-result branching and quality gate while deferring only the commit
  • Replace "run quality-fixer before every commit" with the positive precondition: commit only after approved or verification_incomplete
  • Fix-cycle handoff: keep post-implementation corrections uncommitted through the loop; commit applied corrections once at Review Resolution convergence
  • Fix-cycle handoff: route executor-owned corrections through the per-task cycle's step 2, so the conditional integration-test-reviewer path is not skipped when a correction changes integration/E2E tests
  • Final Cleanup: make the pre-cleanup commit an explicit step instead of an assumption ("Their work is committed")
  • Bump plugin versions to 0.25.6

Files: recipe-build, recipe-front-build, recipe-implement, recipe-fullstack-implement, subagents-orchestration-guide, synced to the three plugin directories.

Verification

  • node scripts/sync-plugins.mjs --check — in sync
  • claude plugin validate — marketplace and all four plugins pass
  • pre-commit hooks (sync, validate, skills index) pass

🤖 Generated with Claude Code

The build and implement recipes declared the 4-step task cycle as
MANDATORY without stating its scope, and phrased the quality gate as
"run quality-fixer before every commit". Together these read as "a
quality-fixer pass means commit", so the post-implementation review loop
generated one commit per findings round even though no rule requires it.

- Scope the mandatory 4-step cycle to the Consumed Task Set, and state
  that corrections outside it reuse the executor-result branching and
  quality gate while deferring only the commit
- Replace "run quality-fixer before every commit" with the positive
  precondition: commit only after approved or verification_incomplete
- Fix-cycle handoff: keep post-implementation corrections uncommitted;
  reviewers read the working tree, and applied corrections are committed
  once at Review Resolution convergence
- Fix-cycle handoff: route executor-owned corrections through the
  per-task cycle's step 2 so the conditional integration-test-reviewer
  path is not skipped
- Final Cleanup: make the pre-cleanup commit an explicit step instead of
  an assumption
- Bump plugin versions to 0.25.6

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@shinpr shinpr self-assigned this Sep 7, 2026
@shinpr
shinpr merged commit 6d58447 into main Sep 7, 2026
1 check passed
@shinpr
shinpr deleted the fix/scope-review-loop-commits branch September 7, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant