Repository navigation
AppDeviceBridge maps: pluggable providers with Azure Maps and Google Maps - #12
Merged
Merged
Conversation
…Maps Document the basemap, router and geocoder providers (OpenStreetMap, Azure Maps, Google Maps, or your own), add the 1.2 feature and breaking release notes, and regenerate the bridge API reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Several routing and basemap descriptions conflict with the documented runtime behavior.
Review effort: Balanced
Findings: 3
Open (3)
What changed in this PR
Documents pluggable map, routing, and geocoding providers for AppDeviceBridge.
Changes:
- Adds Azure Maps, Google Maps, and custom-provider guidance.
- Updates release notes, package summaries, and generated bridge API data.
- Refreshes the Maps sidebar date.
| File | Description |
|---|---|
src/sidebar-topics.mjs |
Updates the Maps page date. |
src/data/appdevicebridge/bridges.json |
Adds generated provider API contracts. |
src/content/docs/appdevicebridge/release-notes.mdx |
Documents features and breaking changes. |
src/content/docs/appdevicebridge/maps.mdx |
Adds provider setup and API guidance. |
src/content/docs/appdevicebridge/index.mdx |
Updates Maps package summaries. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| ``` | ||
|
|
||
| Set `Cacheable = true` on the layer only if the service's terms allow tiles to be kept on the device. |
Comment on lines
+180
to
+182
| `Directions.Router`. A router declares the travel modes it offers: `GET /_bridge/directions` reports them as | ||
| `onlineModes`, with the router's name as `router`, and a request for another mode answers `400 mode_unsupported` when the | ||
| device can't route it either. Every route carries the `Attribution` its source requires; show it with the route. |
| "verb": "POST", | ||
| "route": "directions/route", | ||
| "summary": "Computes a route through the stops. Fails with 400 for fewer than two stops or a stop off the map, 404 when no route connects them, 503 (`offline_unavailable`) when the device cannot compute it and the online router cannot be reached, 501 when neither is available on this platform and app.", | ||
| "summary": "Computes a route through the stops. Fails with 400 for fewer than two stops or a stop off the map, or (`mode_unsupported`) for a travel mode the online router does not offer when the device cannot route; 404 when no route connects them, 503 (`offline_unavailable`) when the device cannot compute it and the online router cannot be reached, 501 when neither is available on this platform and app.", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs for shinyorg/appdevicebridge#3, which makes the maps bridge's basemap, router and geocoder pluggable providers, with OpenStreetMap, Azure Maps and Google Maps built in.
appdevicebridge/maps.mdx:IBasemapProviderorIRouteProvider.BasemapandDirections.Router.AzureMapsCredential.400 mode_unsupportedand502 router_error.appdevicebridge/release-notes.mdx: a 1.2 feature note and a breaking-change note.appdevicebridge/index.mdx: the Maps and Maps.Blazor package rows.src/data/appdevicebridge/bridges.json: regenerated withscripts/extract-bridges.mjs; the diff only touches maps.src/sidebar-topics.mjs: the maps page'sdateUpdated.Testing
npx astro buildsucceeds: 822 pages built.🤖 Generated with Claude Code