Re-apply CI fixes for GitHub-hosted runners#20
Conversation
The upstream merge overwrote our previous CI customizations (commits 2b89649, f932354, 6f61cfd, 197e953). This re-applies the same fixes: - Replace all namespace-profile-ghostty-* runners with ubuntu-24.04/macos-latest - Remove ghostty-org/ghostty repository guards from job conditions - Use workspace-relative Zig cache dirs instead of Namespace Cloud paths - Strip namespacelabs/nscloud-cache-action steps (30 instances) - Revert test-debian-13 from Namespace Buildx to plain docker build
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be0b4602bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| test: | ||
| if: github.repository == 'ghostty-org/ghostty' && needs.skip.outputs.skip != 'true' | ||
| if: needs.skip.outputs.skip != 'true' |
There was a problem hiding this comment.
Dropping the repository check from test makes trigger-snap reachable on normal push events in this fork, and that job dispatches .github/workflows/snap.yml; however, snap.yml still targets namespace-profile-ghostty-snap* runners (lines 21-22), so in the hosted-runner setup this commit is migrating to, each push can spawn a Snap run that cannot be scheduled. Keep the upstream/fork guard on this execution path (or migrate snap.yml first) to avoid repeatedly triggering an unrunnable workflow.
Useful? React with 👍 / 👎.
These jobs dispatch snap.yml and flatpak.yml which still use namespace runners. Without the guard, every push to the fork spawns unschedulable workflow runs.
test.yml had formatting issues caught by prettier check. GitDiff feature files import AppKit (macOS-only) but were being compiled for the Ghostty-iOS target via the file system synchronized group. Add all GitDiff files to the iOS membershipExceptions list, matching the pattern used for other macOS-only features.
9 for_where violations: convert for/if to for/where clauses. 2 large_tuple violations: suppress with inline disable comments. These are pre-existing in Ghostree code but now caught because the repo guard preventing CI from running was removed.
…S target Both files import AppKit and were missing from the iOS target's membershipExceptions list, causing the Ghostty-iOS build to fail.
References AgentHookInstaller and AgentStatusPaths which are defined in Worktrunk files already excluded from iOS.
The icon set only had mac idiom entries, causing the iOS build to fail with "did not have any applicable content". Add a universal iOS entry reusing the 1024x1024 icon (512x512@2x).
1 participant
Summary
namespace-profile-ghostty-*runner labels withubuntu-24.04/macos-latestgithub.repository == 'ghostty-org/ghostty'guards so jobs actually run on our fork${{ github.workspace }}/.zig-cache/...for Zig cache dirs (writable on hosted runners)namespacelabs/nscloud-cache-actionsteps (Namespace Cloud-specific, added by upstream since our last fix)test-debian-13from Namespace Buildx back to plaindocker build