rust(feat): adding tdms imports#553
Merged
Merged
Conversation
d245f73 to
0d86e2e
Compare
Contributor
Author
|
In the future I will do gradual commits, this is on me should not have done one big commit |
solidiquis
requested changes
May 7, 2026
tsift
reviewed
May 7, 2026
added 7 commits
May 7, 2026 13:02
tsift
approved these changes
May 11, 2026
solidiquis
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
tdms cratedetect_config()on the backend, so we still find the timestamp properties or timestamp channel to ensure parity between what is shown in preview and what will be found when passing it into the backend--preview, we are still sending the raw bytes to the backend to be parsed there. This is because of limitation with thetdms crateand that it does not have functionality for all tdms data types. In the preview if we hit a data type that thetdms cratedoes not know, we output an error alongside it to tell the user that even if its not able to be previewed here it could still be properly imported into sift.Validation