Skip to content

rust(feat): adding tdms imports#553

Merged
Brandon-Shippy merged 9 commits into
mainfrom
rust/adding-tdms-imports
May 11, 2026
Merged

rust(feat): adding tdms imports#553
Brandon-Shippy merged 9 commits into
mainfrom
rust/adding-tdms-imports

Conversation

@Brandon-Shippy
Copy link
Copy Markdown
Contributor

What was changed

  • Added TDMS Import functionality to Rust CLI
  • Added tdms crate
  • For --preview added some client-side parsing that matches that of detect_config() on the backend, so we still find the timestamp properties or timestamp channel to ensure parity between what is shown in preview and what will be found when passing it into the backend
  • Note that we are parsing the tdms file client-side specifically for --preview, we are still sending the raw bytes to the backend to be parsed there. This is because of limitation with the tdms crate and that it does not have functionality for all tdms data types. In the preview if we hit a data type that the tdms crate does not know, we output an error alongside it to tell the user that even if its not able to be previewed here it could still be properly imported into sift.

Validation

  • Added a suite of unit tests
  • Validated imports with manual tests, testing with error prone tdms files and proper tdms files.

@Brandon-Shippy Brandon-Shippy force-pushed the rust/adding-tdms-imports branch from d245f73 to 0d86e2e Compare May 6, 2026 22:12
@Brandon-Shippy
Copy link
Copy Markdown
Contributor Author

In the future I will do gradual commits, this is on me should not have done one big commit

@Brandon-Shippy Brandon-Shippy requested a review from wei-qlu May 6, 2026 23:32
@Brandon-Shippy Brandon-Shippy changed the title Rust(feat): adding tdms imports rust(feat): adding tdms imports May 7, 2026
@Brandon-Shippy Brandon-Shippy requested a review from tsift May 7, 2026 18:31
Comment thread rust/crates/sift_cli/src/cli/mod.rs Outdated
Comment thread rust/crates/sift_cli/src/cmd/import/tdms/detect_tdms_config.rs Outdated
Comment thread rust/crates/sift_cli/src/cmd/import/tdms/detect_tdms_config.rs Outdated
Comment thread rust/crates/sift_cli/src/cmd/import/tdms/detect_tdms_config.rs Outdated
Comment thread rust/crates/sift_cli/src/cmd/import/tdms/tests.rs Outdated
@Brandon-Shippy Brandon-Shippy requested review from solidiquis and tsift May 7, 2026 21:37
@Brandon-Shippy Brandon-Shippy merged commit d1cbf7e into main May 11, 2026
20 checks passed
@Brandon-Shippy Brandon-Shippy deleted the rust/adding-tdms-imports branch May 11, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants