support for RSA-signed certificate chains and non-standard signing algorithms #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fbfa39e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bdehamer
force-pushed
the
bdehamer/expand-bundle-verification-support
branch
2 times, most recently
from
042361e to
dce442f
Compare
Signed-off-by: Ishan Mundra <[email protected]>
Signed-off-by: Brian DeHamer <[email protected]>
Signed-off-by: Brian DeHamer <[email protected]>
Signed-off-by: Brian DeHamer <[email protected]>
bdehamer
force-pushed
the
bdehamer/expand-bundle-verification-support
branch
from
dce442f to
fbfa39e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1507
Original PR #1508 opened by @imundra
Summary
Hey yall! I'm working on a software team that's looking to adopt sigstore for signing/verification of artifacts internally. We were able to fly through the signing and verification using the Go module but were running into issues verifying using the JS library for the same bundles that were able to be verified by sigstore-go.
In this PR, I'm looking to add support for verification of more complex/non-standard certificates that were used to sign and generate bundles to cover more of our internal PKI use cases 🙂. Let me know if there are any concerns/questions!
Release Note