Skip to content

Make logic in resume-translate-service more robust#3699

Merged
RaymondLuong3 merged 1 commit intomasterfrom
fix/resume-translate-logic
Mar 6, 2026
Merged

Make logic in resume-translate-service more robust#3699
RaymondLuong3 merged 1 commit intomasterfrom
fix/resume-translate-logic

Conversation

@Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Feb 19, 2026

The resume checking service recently had some bugs fixed related to incorrectly assuming the first book in a project's list of books is the first book canonically. The resume translate service had the same bug; it was just never reported as a Jira issue. This PR fixes it.

It also makes a similar fix in project.component.ts

This change is Reviewable


Open with Devin

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.33%. Comparing base (74ed20b) to head (e0819b5).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../app/checking/checking/resume-translate.service.ts 81.81% 0 Missing and 2 partials ⚠️
...ure/ClientApp/src/app/project/project.component.ts 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3699   +/-   ##
=======================================
  Coverage   81.32%   81.33%           
=======================================
  Files         620      620           
  Lines       39031    39037    +6     
  Branches     6341     6359   +18     
=======================================
+ Hits        31743    31749    +6     
+ Misses       6318     6304   -14     
- Partials      970      984   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami force-pushed the fix/resume-translate-logic branch 3 times, most recently from bc3c9ae to 722dbd3 Compare February 19, 2026 20:09
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@Nateowami Nateowami marked this pull request as ready for review March 3, 2026 02:20
@RaymondLuong3 RaymondLuong3 self-assigned this Mar 6, 2026
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@RaymondLuong3 RaymondLuong3 force-pushed the fix/resume-translate-logic branch from 722dbd3 to e0819b5 Compare March 6, 2026 19:10
@RaymondLuong3 RaymondLuong3 merged commit 6ef8e7b into master Mar 6, 2026
24 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/resume-translate-logic branch March 6, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants